JS: update externs from closure-compiler #4955
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Still in progress.
Inspired by this anomalous result, which is fixed by this PR.
Reviewing this PR is hard, so I'll explain how it was created.
I went through our externs and updated all the files that originated from
closure-compiler
to their latest version.Started by copy-pasting the
externs/browser
folder fromclosure-compiler
into ourexterns/web
.I didn't update the
nodejs
folder, as the externs I found inclosure-compiler
were not structured in the same way, which gave FPs in some queries.Then I went through all the
externs
that had not been touched, and updated the ones fromclosure-compiler
to their latest version.This means that the
contrib/externs
folder fromclosure-compiler
has not been copy-pasted into ourexterns
.There are a few files that have been moved/deleted:
.fileapi.js
has been renamed tononstandard_fileapi.js
intl.js
file was duplicated between theweb
andes
folder. I left the one ines
.w3c_encoding.js
was duplicate ofwhatwg_encoding.js
. I've left the latter.TODO: