Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: update externs from closure-compiler #4955

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jan 13, 2021

NOTE: Still in progress.


Inspired by this anomalous result, which is fixed by this PR.

Reviewing this PR is hard, so I'll explain how it was created.

I went through our externs and updated all the files that originated from closure-compiler to their latest version.

Started by copy-pasting the externs/browser folder from closure-compiler into our externs/web.
I didn't update the nodejs folder, as the externs I found in closure-compiler were not structured in the same way, which gave FPs in some queries.

Then I went through all the externs that had not been touched, and updated the ones from closure-compiler to their latest version.

This means that the contrib/externs folder from closure-compiler has not been copy-pasted into our externs.

There are a few files that have been moved/deleted:

  • fileapi.js has been renamed to nonstandard_fileapi.js.
  • The intl.js file was duplicated between the web and es folder. I left the one in es.
  • w3c_encoding.js was duplicate of whatwg_encoding.js. I've left the latter.

TODO:

  • very large evaluation
  • change note?

@erik-krogh erik-krogh added the Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish label Jan 13, 2021
@github-actions github-actions bot added the JS label Jan 13, 2021
@erik-krogh erik-krogh added the WIP This is a work-in-progress, do not merge yet! label Jan 20, 2021
@erik-krogh erik-krogh force-pushed the updateExterns branch 2 times, most recently from 4f1b8ac to 3b3f642 Compare January 22, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish JS WIP This is a work-in-progress, do not merge yet!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant