add tenant-id and client-id to credentials #1553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
tenant-and-client-id
branch
4 times, most recently
from
2835d0c to
a934023
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for forwarding tenant-id and client-id credential values to the job's credentials metadata, ensuring these values reach the proxy. This follows the established pattern used for Python's index-url value.
- Added
tenant-idandclient-idfields to the Credential type definition - Implemented forwarding logic in the credential processing to include these fields in metadata
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/api-client.ts | Added optional tenant-id and client-id fields to Credential type |
| src/updater.ts | Implemented forwarding logic for tenant-id and client-id to credentials metadata |
| tests/updater.test.ts | Added test case verifying tenant-id and client-id are properly forwarded |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jakecoffman
approved these changes
Oct 14, 2025
brettfo
force-pushed
the
tenant-and-client-id
branch
from
a934023 to
4208ce2
Compare
brettfo
changed the title
jakecoffman
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
tenant-idandclient-idare allowed values in the API client so they get serialized properly. The credentials are passed through to the proxy here.