Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is completely incorrect, filter only works without quotes #36213

Closed
wants to merge 1 commit into from

Conversation

cyberious
Copy link

Why:

The documentation is incorrect, it suggests that the query needs to be wrapped in a single quote, while in fact it breaks when you attempt to do this. After speaking with support they confirmed that it is in fact an issue with docs. I have tested and confirmed in our environment.

If you provide quotes around the query, as an example for group list you will receive a response of:

{
  "schemas": [
    "urn:ietf:params:scim:api:messages:2.0:Error"
  ],
  "status": 400,
  "scimType": "invalidFilter",
  "detail": "Only single 'eq' operators are supported."
}

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the preview environment.

Copy link

welcome bot commented Feb 7, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

🚀 Manual Deployment Required

It looks like this pull request contains code changes. To preview these changes, an internal Hubber will need to manually deploy the changes to one of our staging servers.

Thank you for your contribution!

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • src/rest/data/ghec-2022-11-28/schema.json

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

@cyberious
Copy link
Author

Closing this change, but YOU must change upstream as you are unable to update this as part of the documentation site

@cyberious cyberious closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant