Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify key type for SSH authentication #36293

Closed
wants to merge 1 commit into from

Conversation

dariocurr
Copy link
Contributor

Why:

Clarify that you need to add an authentication key when you are following the guide to authenticate with SSH

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the preview environment.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 14, 2025
Copy link
Contributor

👓 How to review these changes

Thank you for your contribution. To review these changes, you can:

  1. Spin up a codespace
  2. Set up a local development environment

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server
This table is posted from the Content Changes Table Comment workflow.

🤖 This comment is automatically generated.

@subatoi
Copy link
Contributor

subatoi commented Feb 14, 2025

Hi @dariocurr, thank you for raising a PR; however I'm afraid on this occasion we won't be accepting this contribution.

We're aware of improvements needed for this and other articles, and work is scoped for that internally; I don't want to pre-empt that here, because it should be clear enough in the context, and in the article that's linked to. I can't give you a timeframe for when you'll see improvements to the content here, but I have noted your suggestion.

In general, so you have the optimal experience, I'd recommend opening an issue first so we can review any proposals. That obviously isn't always the best option and it's not a perfect science, though.

Thank you very much for your interest in the docs! Please feel free to take a look at our issues marked help wanted, as well.

@subatoi subatoi closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants