Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint for Enforcement Status for Rulesets #36807

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

david-graesser
Copy link
Contributor

@david-graesser david-graesser commented Mar 13, 2025

Why:

Closes: 36801

What's being changed (if available, include any code snippets, screenshots, or gifs):

This change will extend the description how to setup a Ruleset for Copilot for the following 2 paragraphs:
Configuring automatic code review for a single repository
Configuring automatic code review for repositories in an organization

Point 5 will be replaced by this change with the hint that the "Enforcement Status" should be set to Active to ensure that the ruleset is taken into account.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@Copilot Copilot bot review requested due to automatic review settings March 13, 2025 14:20
Copy link

welcome bot commented Mar 13, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the guidance for configuring rulesets by adding a hint to set the "Enforcement Status" to Active.

  • Extends the ruleset configuration instructions
  • Clarifies the necessary enforcement status for the ruleset to be taken into account
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 13, 2025
Copy link
Contributor

github-actions bot commented Mar 13, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
copilot/using-github-copilot/code-review/configuring-automatic-code-review-by-copilot.md fpt
ghec
fpt
ghec
from reusable

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@subatoi subatoi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 13, 2025
@subatoi
Copy link
Contributor

subatoi commented Mar 13, 2025

Many thanks @david-graesser, we'll review this as soon as we can

Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @david-graesser, I just applied a small change that's purely based on our style guide.

I'll get this merged for you now—many thanks for spotting this and raising an issue, and then creating a PR ✨

@subatoi subatoi enabled auto-merge March 14, 2025 11:33
@subatoi subatoi added this pull request to the merge queue Mar 14, 2025
Merged via the queue into github:main with commit 0c47b74 Mar 14, 2025
42 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hint for Enforcement status for Ruleset
2 participants