Skip to content

Conversation

@GrantBirki
Copy link
Contributor

@GrantBirki GrantBirki commented Jul 15, 2025

This pull request improves the test suites around yaml file expirations.

This PR only updates tests and no actual logic that is used in production code/deployments.

Copilot AI review requested due to automatic review settings July 15, 2025 20:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the test coverage for YAML file expiration functionality by adding comprehensive test cases and fixture files. The changes focus on improving validation of how the system handles various expiration scenarios in YAML configuration files.

  • Adds 6 new YAML test fixture files covering different expiration scenarios (individual usernames, groups, nested structures, invalid dates, etc.)
  • Expands the test suite with 6 new test contexts covering edge cases and complex expiration logic
  • Adds explanatory comments to clarify test expectations and improve test maintainability

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
spec/unit/fixtures/ldap-config/yaml/expiration-mixed-nested.yaml Test fixture for mixed expiration scenarios with nested and/or structures
spec/unit/fixtures/ldap-config/yaml/expiration-invalid-date.yaml Test fixture containing invalid date format to test error handling
spec/unit/fixtures/ldap-config/yaml/expiration-individual-usernames.yaml Test fixture for individual username expiration scenarios
spec/unit/fixtures/ldap-config/yaml/expiration-ignore-test.yaml Test fixture for testing expiration ignoring functionality
spec/unit/fixtures/ldap-config/yaml/expiration-groups.yaml Test fixture for group-level expiration testing
spec/unit/fixtures/ldap-config/yaml/expiration-all-individual-expired.yaml Test fixture where all entries are expired
spec/unit/entitlements/data/groups/calculated/yaml_spec.rb Main test file with expanded test coverage for all expiration scenarios

@GrantBirki GrantBirki merged commit 0e09396 into main Jul 16, 2025
18 checks passed
@GrantBirki GrantBirki deleted the yaml-exp-tests branch July 16, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants