feat: migrate to ESM only #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the repo to be of `type: "module"` (i.e. ESM). ESLint already uses a dynamic import to load plugins, so this will only affect CommonJS users with flat config in Node <20.
43081j
commented
Mar 19, 2025
| @@ -0,0 +1,5 @@ | |||
| const svgElementAttributes = require('svg-element-attributes') | |||
There was a problem hiding this comment.
This file is unfortunate but we have to jump back into cjs in order to load these two JSON files
If we use an import , we need to use import attributes (node 20)
One day when we bump the minimum node version, we should move this back into esm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All LTS versions of node will soon support
require(esm)as18.xwill fall out of long term support imminentlyESLint also already loads plugins via a dynamic import, so if we make this change it means the only people affected are those writing flat configs as CommonJS in Node <20
Depends on #621 since this makes the lint rules apply again (they currently don't in main)