Skip to content

Commit 6e1f922

Browse files
lpcoxCopilot
andcommitted
fix: address review feedback on docs pre-fetch
- Add set -o pipefail so curl failures are detected and emit '(not found)' instead of silently producing empty content - Write pre-fetched docs to workspace file instead of $GITHUB_OUTPUT, since steps compile into the agent job but the prompt is rendered in the activation job — ${{ steps.fetch-docs.outputs.DOCS_CONTENT }} would always be empty - Remove stale GH_AW_EXPR_D5B28826 env vars from activation job - Prompt now instructs the agent to read .pelis-agent-factory-docs.txt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent b7fe721 commit 6e1f922

2 files changed

Lines changed: 19 additions & 23 deletions

File tree

.github/workflows/pelis-agent-factory-advisor.lock.yml

Lines changed: 1 addition & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/pelis-agent-factory-advisor.md

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -27,21 +27,22 @@ steps:
2727
- name: Fetch Pelis Agent Factory Docs
2828
id: fetch-docs
2929
run: |
30+
set -o pipefail
3031
BASE="https://github.github.io/gh-aw"
31-
DELIM="PELIS_DOCS_$(date +%s%N)"
32-
{
33-
echo "DOCS_CONTENT<<${DELIM}"
34-
for PATH_SUFFIX in \
35-
"/blog/2026-01-12-welcome-to-pelis-agent-factory/" \
36-
"/introduction/overview/" \
37-
"/guides/workflow-patterns/" \
38-
"/guides/best-practices/"; do
39-
echo "### ${BASE}${PATH_SUFFIX}"
40-
curl -sf "${BASE}${PATH_SUFFIX}" | python3 -c "import sys,html,re;t=sys.stdin.read();print(html.unescape(re.sub('<[^>]+>','',t))[:8000])" 2>/dev/null || echo "(not found)"
41-
echo ""
42-
done
43-
echo "${DELIM}"
44-
} >> "$GITHUB_OUTPUT"
32+
OUTFILE="${GITHUB_WORKSPACE}/.pelis-agent-factory-docs.txt"
33+
: > "$OUTFILE"
34+
for PATH_SUFFIX in \
35+
"/blog/2026-01-12-welcome-to-pelis-agent-factory/" \
36+
"/introduction/overview/" \
37+
"/guides/workflow-patterns/" \
38+
"/guides/best-practices/"; do
39+
echo "### ${BASE}${PATH_SUFFIX}" >> "$OUTFILE"
40+
curl -sf "${BASE}${PATH_SUFFIX}" \
41+
| python3 -c "import sys,html,re;t=sys.stdin.read();print(html.unescape(re.sub('<[^>]+>','',t))[:8000])" \
42+
>> "$OUTFILE" 2>/dev/null \
43+
|| echo "(not found)" >> "$OUTFILE"
44+
echo "" >> "$OUTFILE"
45+
done
4546
---
4647

4748
# Pelis Agent Factory Advisor
@@ -59,13 +60,12 @@ knowledge of the patterns. Store the new hash value if it has changed.
5960

6061
### Pre-fetched Documentation
6162

62-
The following Pelis Agent Factory documentation was pre-fetched from the site:
63-
64-
${{ steps.fetch-docs.outputs.DOCS_CONTENT }}
63+
Pelis Agent Factory documentation was pre-fetched and saved to `.pelis-agent-factory-docs.txt`
64+
in the workspace root. Read this file with `cat .pelis-agent-factory-docs.txt` to access the content.
6565

6666
### Step 1.1: Review Pre-fetched Documentation
6767

68-
Review the pre-fetched documentation above and note key patterns and best practices.
68+
Read `.pelis-agent-factory-docs.txt` and note key patterns and best practices.
6969
Pay special attention to:
7070
- Workflow patterns and templates
7171
- Best practices for agentic automation

0 commit comments

Comments
 (0)