Skip to content

fix: scanner workflows now check closed issues with state_reason-aware dedup #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 3 commits into from
May 8, 2026
Merged

fix: scanner workflows now check closed issues with state_reason-aware dedup #2740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
782fac9
fix: scanner workflows now check closed issues to prevent re-filing
lpcox May 8, 2026
00d1ec6
fix: refine scanner dedup guidance for closed issue handling
Copilot May 8, 2026
e85b43d
fix: align scanner dedup rules with GitHub state_reason semantics
Copilot May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/duplicate-code-detector.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions .github/workflows/duplicate-code-detector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,12 @@ cat containers/api-proxy/proxy-utils.js 2>/dev/null | head -60

## Phase 5: Check for Existing Issues

Before filing new issues, check what's already been reported:
Before filing new issues, check BOTH open AND closed issues:

1. Search for open issues with `[Duplicate Code]` prefix using the GitHub toolset
2. Also search for issues with labels `code-quality` or `refactoring` that describe duplication
1. Search for issues with `[Duplicate Code]` prefix using the GitHub toolset with `state: all` (or equivalent `is:open` + `is:closed`)
2. Also search for issues with labels `code-quality` or `refactoring` that describe duplication using `state: all` (or equivalent `is:open` + `is:closed`)
3. Skip any finding that already has an open tracking issue
4. For matching closed issues, check the GitHub `state_reason`: **auto-skip only when `state_reason` is `not_planned`** (often shown as "won't fix" / "not planned"). If `state_reason` is `completed` and the finding still reproduces, reopen the prior issue or file a new one with fresh evidence and a link to the prior issue.

## Phase 6: Prioritize and Report Findings

Expand Down Expand Up @@ -213,7 +214,7 @@ Low / Medium / High
- **Be specific**: Always include file paths and line numbers in the evidence section
- **Be actionable**: Each issue should have a clear, implementable suggestion
- **Avoid noise**: Only file issues for genuine duplication with real maintenance impact — not cosmetic similarities
- **No duplicates**: Check existing open issues before creating new ones
- **No duplicates**: Check existing issues with `state: all`; only treat closed issues as terminal when `state_reason` is `not_planned`
- **Security awareness**: Flag duplicated security-critical logic (domain validation, ACL rules, capability management) with higher urgency
- **Cap at 5 issues**: File at most 5 issues per run to avoid flooding the tracker

Expand Down
Loading
Loading