[log] Add debug logging to guard/wasm_payload.go policy validation#4841
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
[log] Add debug logging to guard/wasm_payload.go policy validation#4841github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Add logWasm debug logging to key policy payload functions: - normalizePolicyPayload: log string policy parsing entry/result - buildStrictLabelAgentPayload: log validation entry and success with policy fields - BuildLabelAgentPayload: log trusted-bots/users injection counts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds
logWasmdebug logging calls tointernal/guard/wasm_payload.gofor improved troubleshooting of WASM guard policy validation.Functions enhanced
normalizePolicyPayload— logs when a string policy is received (with length) and whether parsing succeeded or the policy was passed through unchangedbuildStrictLabelAgentPayload— logs validation entry and success with the resolvedreposandmin-integrityvaluesBuildLabelAgentPayload— logs the counts oftrusted-botsandtrusted-usersbeing injected, and confirms injection into theallow-onlyobjectWhy
wasm_payload.gocontains dense policy validation logic. When guard policy issues occur in production, there was no debug signal to trace which validation step failed or what values were being processed. These log calls use the existinglogWasmlogger (declared inwasm.go, same package) and follow thepkg:filenamenaming convention already established.Validation
go build ./...✅go test ./internal/guard/...✅