Handle wrapped jsonschema validation errors in config schema formatting#7385
Merged
Conversation
Copilot
AI
changed the title
[WIP] Update santhosh-tekuri/jsonschema to version v6.0.2
Handle wrapped jsonschema validation errors in config schema formatting
Jun 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves config JSON Schema validation error formatting by ensuring wrapped *jsonschema.ValidationError instances still receive the detailed, location-aware formatting (including recursive causes and the docs footer), instead of falling back to the generic error string path.
Changes:
- Updated
formatSchemaErrorto detect*jsonschema.ValidationErrorviaerrors.As(handles wrapped errors). - Added a regression test covering a wrapped
jsonschema.ValidationErrorto ensure detailed formatting is preserved.
Show a summary per file
| File | Description |
|---|---|
| internal/config/validation_schema.go | Switches schema error detection to errors.As so wrapped validation errors keep rich formatting output. |
| internal/config/validation_schema_error_format_test.go | Adds a targeted test that wraps a ValidationError and asserts the detailed formatting branch is used. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatSchemaErroronly recognized direct*jsonschema.ValidationErrorvalues, so wrapped schema errors were downgraded to the generic error path and lost location/cause diagnostics. This change makes schema error formatting resilient to wrapping while preserving existing output behavior for direct and non-schema errors.Schema error unwrapping
formatSchemaErrorfrom direct type assertion toerrors.Aswhen detecting*jsonschema.ValidationError.Targeted regression coverage
jsonschema.ValidationErrorto ensure the detailed formatting branch is used.