refactor: move outlier functions to semantically correct files/packages#7394
Draft
Copilot wants to merge 2 commits into
Draft
refactor: move outlier functions to semantically correct files/packages#7394Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Refactor JSON utility in string utility package
refactor: move outlier functions to semantically correct files/packages
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four functions lived in files that didn't match their purpose. This moves each to its natural home with no logic changes.
Changes
strutil/json_clone.go(new) — extractsDeepCloneJSONfromstrutil.go; JSON deep-clone has nothing to do with string utilitiesmcp/helpers.go(new) — extractsmarshalToResponse,unmarshalParams, andcallParamMethodfrompagination.go; these are general-purpose MCP helpers consumed byconnection_methods.go, not pagination-specific codeserver/middleware.go— moveswithResponseLoggingfromhttp_helpers.go; it's anhttp.Handlerdecorator and belongs alongsideWithOTELTracing,authMiddleware,WithSDKLogging, etc.mcpresult/mcpresult.go(new, replacescontent_items.go+text_content.go) — consolidates two tiny single-function files into one;NormalizeContentItemsandExtractTextContentform a single logical unitFinding 5 (
AgentTagsSnapshotinmcp/connection_logging.go) is left as-is pending circular import analysis.