Fix spurious check_token_telemetry failure in Smoke Cursor workflow#57313
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot reconfigure cursor.md to |
Looked into this before making further changes: Separately, even if cursor-agent could be redirected, the AWF api-proxy's So routing Cursor through api-proxy isn't achievable from |
|
Great work, The changes are focused and well-explained:
The PR looks ready for review and merge. Nice alignment with the project's workflow patterns! Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
|
Category: bug | Risk: medium | Score: 46/100 (impact 16/50, urgency 14/30, quality 16/20) | Action: defer | Batch: workflow-automation
|
|
Category: bug | Risk: medium | Score: 46/100 (impact 16/50, urgency 14/30, quality 16/20) | Action: defer | Batch: workflow-automation
|
|
Category: bug | Risk: medium | Score: 61/100 (impact 28/50, urgency 18/30, quality 15/20) | Action: fast_track | Batch: workflow-reliability Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
[!TIP] tools:
github:
mode: gh-proxySee GitHub Tools for more information on To allow these domains, add them to the network:
allowed:
- defaults
- "api.github.com"See Network Configuration for more information.
|
|
Category: bug | Risk: medium | Score: 61/100 (impact 28/50, urgency 18/30, quality 15/20) | Action: fast_track | Batch: workflow-reliability Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
[!TIP] tools:
github:
mode: gh-proxySee GitHub Tools for more information on To allow these domains, add them to the network:
allowed:
- defaults
- "api.github.com"See Network Configuration for more information.
|
|
Category: bug | Risk: medium | Score: 70 (impact 34/50, urgency 24/30, quality 12/20) | Action: fast_track | Batch: workflow-automation. Small workflow fix for repeated smoke-cursor failures; prioritize it because it directly affects CI reliability. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
[!TIP] tools:
github:
mode: gh-proxySee GitHub Tools for more information on To allow these domains, add them to the network:
allowed:
- defaults
- "api.github.com"See Network Configuration for more information.
|
|
Category: bug | Risk: medium | Score: 58 (impact 24, urgency 18, quality 16) | Action: batch_review | CI: success | Small workflow reliability fix; draft status and no review blocker.
|
|
Category: bug | Risk: medium | Score: 52 (impact 20 + urgency 18 + quality 14) | Action: batch_review | Batch: workflow-automation. Workflow reliability fix with a clear root cause and successful CI.
|
|
Category: bug Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
[!TIP] tools:
github:
mode: gh-proxySee GitHub Tools for more information on To allow these domains, add them to the network:
allowed:
- defaults
- "api.github.com"See Network Configuration for more information.
|
|
Category: bug | Risk: medium | Score: 66/100 (impact 30/50, urgency 22/30, quality 14/20)
|
|
Category: bug | Risk: medium | Score: 61 | Action: fast_track | Batch: awf-runtime Note: Workflow failure was active and fix is small and targeted.
|
|
Category: bug | Risk: medium | Score: 58 (impact 25 + urgency 17 + quality 16) | Action: batch_review | CI: passing (1/1) | Batch: workflow-reliability Workflow false-positive fix; good candidate for grouped review.
|
|
Category: bug | Risk: medium | Score: 58 (impact 32 + urgency 15 + quality 11) | Action: fast_track | Batch: none
|
|
Category: bug | Risk: medium | Score: 58 (impact 32 + urgency 15 + quality 11) | Action: fast_track | Batch: none
|
|
Category: bug | Risk: medium | Score: 51 (impact 24 urgency 18 quality 9) | Action: batch_review | Batch: workflow-reliability Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
[!TIP] tools:
github:
mode: gh-proxySee GitHub Tools for more information on To allow these domains, add them to the network:
allowed:
- defaults
- "api.github.com"See Network Configuration for more information.
|
|
Category: bug | Risk: medium | Score: 53 | Breakdown: impact 28/urgency 16/quality 9 | Action: defer | Batch: workflow-reliability
|
The
check_token_telemetryjob in the Smoke Cursor workflow was failing on every run becausetoken_usage.jsonlwas always empty for Cursor.api2.cursor.sh) directly rather than through gh-aw's universal LLM provider proxy, so it never producestoken_usage.jsonl. The telemetry check assumes proxy-routed engines and was misapplied here.shared/token-telemetry-check.mdimport fromsmoke-cursor.md, aligning it withshared/aider.mdand other direct-API engines that already omit this check for the same reason.smoke-cursor.lock.ymlviagh aw compile, which drops the now-unneededcheck_token_telemetryjob.