Require AWF v0.28.13 for GitHub CLI proxy mode - #58383
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Category: chore | Risk: medium | Score: 42 (impact 24 + urgency 10 + quality 8) | Action: batch_review | Batch: none
|
1 similar comment
|
Category: chore | Risk: medium | Score: 42 (impact 24 + urgency 10 + quality 8) | Action: batch_review | Batch: none
|
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility gate, boundary coverage, and release documentation consistently address the reported proxy failure.
Pull request overview
Adds compile-time enforcement of AWF v0.28.13+ for GitHub CLI proxy mode, preventing known gh issue list and gh pr list failures.
Changes:
- Adds AWF compatibility validation and boundary tests.
- Defines the v0.28.13 CLI-proxy minimum.
- Updates release notes and regenerated workflow artifacts.
File summaries
| File | Description |
|---|---|
pkg/workflow/compiler_validators.go |
Adds CLI-proxy version validation. |
pkg/workflow/compiler_validators_test.go |
Tests default, older, and boundary versions. |
pkg/workflow/awf_feature_flags.go |
Corrects CLI-proxy introduction documentation. |
pkg/constants/version_constants.go |
Defines the minimum compatible AWF version. |
pkg/constants/spec_test.go |
Verifies the new version constant. |
.github/workflows/technical-doc-writer.lock.yml |
Refreshes generated eval execution. |
.github/workflows/smoke-issues.lock.yml |
Refreshes generated PATH setup. |
.github/workflows/glossary-maintainer.lock.yml |
Refreshes generated eval execution. |
.github/workflows/daily-file-diet.lock.yml |
Refreshes generated eval execution. |
.github/workflows/contribution-check.lock.yml |
Refreshes generated eval execution. |
.github/workflows/archie.lock.yml |
Refreshes generated eval execution. |
.changeset/bump-firewall-v0-28-13.md |
Documents restored list-command support. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
@copilot Please take the next forward-progress pass on this PR.
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
Current HEAD is already refreshed against |
gh issue listandgh pr listfail inside older AWF CLI-proxy sidecars becauseghmisclassifies the proxy host as GHES and attempts an invalid version check.Compatibility
tools.github.mode: gh-proxy.Regression coverage
gh issue listandgh pr listfail withmalformed version:inside the agent sandbox undertools.github.mode: gh-proxy(Pi engine) #58371Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.