Preserve setup-action PATH across privileged AWF startup by Copilot · Pull Request #58625 · github/gh-aw

Copilot · 2026-09-04T22:31:10Z

docker-sudo-iptables allowed sudo’s secure_path to replace the runner PATH before AWF captured it, causing setup-selected runtimes such as Ruby 3.4.8 to resolve to system versions instead.

Changes

Privileged invocation
- Restore the caller’s PATH after sudo.
- Execute AWF through trusted absolute paths to prevent PATH-based binary substitution.

sudo -E /usr/bin/env PATH="$PATH" /usr/local/bin/awf

Regression coverage
- Model the sudo boundary with selected, system, and cached Ruby versions.
- Verify the setup-selected Ruby retains precedence while cache-only tools remain discoverable.
Generated workflow
- Refresh the docker-sudo-iptables service-port smoke workflow lock file.

Fixes docker-sudo-iptables loses setup-ruby PATH before AWF #58458

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

🟡 Changes recommended

The user-facing bug fix is missing the required patch changeset for release documentation.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Fixes #58458 by preserving setup-action PATH entries across privileged docker-sudo-iptables AWF startup.

Changes:

Restores the runner PATH after sudo while invoking trusted absolute binaries.
Adds regression coverage for selected and cached Ruby precedence.
Refreshes related assertions and generated workflow output.

File summaries

File	Description
`pkg/constants/constants.go`	Defines the PATH-preserving privileged command.
`pkg/workflow/awf_command_builder.go`	Updates command documentation.
`pkg/workflow/awf_command_builder_test.go`	Verifies the command constant.
`pkg/workflow/engine_helpers_test.go`	Models the sudo PATH boundary.
`pkg/workflow/sandbox_network_isolation_rootless_test.go`	Tests privileged and rootless compilation.
`pkg/workflow/sandbox_custom_agent_test.go`	Updates custom-command assertions.
`pkg/workflow/sandbox_agent_false_test.go`	Updates disabled-sandbox detection.
`pkg/workflow/sandbox_agent_disabled_test.go`	Updates disabled-agent assertions.
`pkg/workflow/firewall_workflow_test.go`	Verifies PATH preservation in legacy mode.
`pkg/workflow/firewall_args_test.go`	Generalizes AWF command messaging.
`pkg/workflow/compiler_permissions_test.go`	Updates rootless-mode assertions.
`pkg/workflow/claude_engine_network_test.go`	Updates privileged-command detection.
`.github/workflows/smoke-service-ports.lock.yml`	Regenerates the smoke workflow command.

Review details

Files reviewed: 13/13 changed files
Comments generated: 1
Review effort level: Balanced

Copilot · 2026-09-05T02:06:37Z

-const AWFLegacySecurityCommand = "sudo -E awf"
+// AWFLegacySecurityCommand runs the trusted system AWF binary with the runner's
+// PATH restored after sudo applies secure_path.
+const AWFLegacySecurityCommand = `sudo -E /usr/bin/env PATH="$PATH" /usr/local/bin/awf`


Addressed in 2f2e28d by adding .changeset/patch-preserve-awf-setup-path.md for the PATH preservation fix.

github-actions · 2026-09-05T01:05:19Z

Generated by 🔧 PR Triage Agent · copilot · mai10 · 24 AIC · ⌖ 2.63 AIC · ⊞ 15.1K · ◷

github-actions · 2026-09-05T01:20:14Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-09-05T01:20:32Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-09-05T01:20:39Z

✅ PR Code Quality Reviewer completed the code quality review.

No inline review comments were needed because no actionable changed-line defects survived adjudication.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-09-05T01:20:52Z

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-09-05T01:20:54Z

✅ Ponytail Reviewer completed successfully!

Lean already. Ship.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by Ponytail Reviewer for #58625

github-actions · 2026-09-05T01:26:24Z

Comment Memory

reviewed_at: 2026-09-05T01:22:43Z
review_event: COMMENT
top_themes:
  - no actionable changed-line correctness or performance regressions found
  - regression coverage exercises sudo secure_path PATH preservation
files_reviewed:
  - .github/workflows/smoke-service-ports.lock.yml
  - pkg/constants/constants.go
  - pkg/workflow/awf_command_builder.go
  - pkg/workflow/awf_command_builder_test.go
  - pkg/workflow/claude_engine_network_test.go
  - pkg/workflow/compiler_permissions_test.go
  - pkg/workflow/engine_helpers_test.go
  - pkg/workflow/firewall_args_test.go
  - pkg/workflow/firewall_workflow_test.go
  - pkg/workflow/sandbox_agent_disabled_test.go
  - pkg/workflow/sandbox_agent_false_test.go
  - pkg/workflow/sandbox_custom_agent_test.go
  - pkg/workflow/sandbox_network_isolation_rootless_test.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 26.1 AIC · ⌖ 8.61 AIC · ⊞ 21.8K · ◷
_{Comment /review to run again}

github-actions

Verdict

No changed-line issues here rise to merge-blocking severity.

Notes

I checked the PATH-preserving sudo rewrite and the regression coverage around selected-vs-cached tool precedence. The new assertions stay aligned with the behavior change, and the one grumpy-coder finding was too brittle to keep because the test intentionally validates the exact privileged command shape introduced by this patch.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 26.1 AIC · ⌖ 8.61 AIC · ⊞ 21.8K
_{Comment /review to run again}

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs — this is a solid, well-targeted root-cause fix with good regression coverage.

📋 Key Themes & Highlights

Key Themes

Correct root cause: sudo's secure_path was clobbering the runner's PATH before AWF captured it; restoring PATH via /usr/bin/env PATH="$PATH" and calling awf by absolute path both fixes the bug and closes a PATH-substitution risk.
Regression test quality: TestDockerSudoIptablesPreservesSelectedRubyPath mirrors the existing TestGetNpmBinPathSetup_PreservesSelectedRuby pattern well, faking sudo to simulate the secure_path boundary and asserting the selected Ruby (not the cached or system one) wins.
Minor gap flagged inline: the hardcoded /usr/local/bin/awf install path isn't cross-checked against the installer script constants — low risk today, but worth a comment or test to prevent silent drift.
Existing bot review comment already flags the missing changeset for this user-facing bug fix (.changeset/ has no entry matching this PR) — worth adding before merge per repo conventions.

Positive Highlights

✅ Fix addresses the actual mechanism (secure_path replacing PATH) rather than papering over symptoms
✅ New test faithfully reproduces the sudo boundary with selected/cached/system Ruby variants
✅ Widely mirrored test-string updates across the suite are consistent and mechanical, not risky

@copilot please address the review comments above.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 41.6 AIC · ⌖ 14.7 AIC · ⊞ 10.3K
_{Comment /matt to run again}

github-actions · 2026-09-05T01:26:34Z

-const AWFLegacySecurityCommand = "sudo -E awf"
+// AWFLegacySecurityCommand runs the trusted system AWF binary with the runner's
+// PATH restored after sudo applies secure_path.
+const AWFLegacySecurityCommand = `sudo -E /usr/bin/env PATH="$PATH" /usr/local/bin/awf`


[/diagnosing-bugs] Good root-cause fix — forcing an absolute-path env restores PATH after sudo's secure_path clobbers it, and using absolute paths for env/awf avoids PATH-based binary substitution. One gap: the hardcoded /usr/local/bin/awf and /usr/bin/env paths are not validated against actions/setup/sh/install_awf_binary.sh's AWF_INSTALL_DIR/AWF_INSTALL_NAME constants anywhere in code or tests — if that install path is ever changed, this string constant will silently drift out of sync.

💡 Suggestion

Consider adding a small comment cross-referencing install_awf_binary.sh's AWF_INSTALL_DIR/AWF_INSTALL_NAME, or a test asserting the two stay consistent, so a future change to the installer doesn't silently break this hardcoded path.

@copilot please address this.

Addressed in 2f2e28d by adding a regression test that parses actions/setup/sh/install_awf_binary.sh and asserts AWFLegacySecurityCommand stays aligned with the non-rootless AWF install path.

github-actions

Reviewed with the impeccable harden/audit lenses (bug-fix change type). This is a backend/CI infra fix (no UI surface), so those modes mostly reduce to correctness/edge-case checks.

Findings: No blocking issues. The AWFLegacySecurityCommand change (sudo -E /usr/bin/env PATH="$PATH" /usr/local/bin/awf) correctly restores the caller PATH after sudo applies secure_path, and pins the AWF invocation to an absolute path to avoid PATH-based binary substitution. All existing assertions that hardcoded the old sudo -E awf string were updated consistently across awf_command_builder_test.go, claude_engine_network_test.go, compiler_permissions_test.go, firewall_workflow_test.go, sandbox_agent_disabled_test.go, sandbox_agent_false_test.go, sandbox_custom_agent_test.go, and sandbox_network_isolation_rootless_test.go. The new TestDockerSudoIptablesPreservesSelectedRubyPath regression test in engine_helpers_test.go is a solid end-to-end simulation of the sudo boundary (selected vs. secure vs. cached Ruby) and correctly asserts the setup-selected Ruby wins while cache tools stay discoverable.

Non-blocking note: An existing bot review comment already flags that this user-facing bug fix is missing a .changeset/*.md entry — confirmed no changeset file was added in this branch. Worth adding before merge per repo release-notes convention, but not a code-correctness issue.

No additional inline comments needed.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

github.com
proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"
    - "proxy.golang.org"

See Network Configuration for more information.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · copilot · sonnet50 · 60.8 AIC · ⌖ 12.4 AIC · ⊞ 8.3K

gh-aw-bot · 2026-09-05T01:56:15Z

pr-sous-chef

@copilot Please take the next forward-progress pass on this PR.

Alpine Container Test is still the notable failed check on the current branch state.
Please investigate that failure, refresh the branch if needed, and run the pr-finisher skill before handing this back to maintainers.
If the code is already correct and the remaining blocker is only CI flakiness or maintainer attention, say that explicitly in your handoff.

Generated by PR Sous Chef: https://github.com/github/gh-aw/actions/runs/33937269999

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 26.3 AIC · ⌖ 8.67 AIC · ⊞ 9.2K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-09-05T02:06:37Z

pr-sous-chef
```...

Investigated the Alpine Container Test: run 33927357465 failed while Docker fetched alpine:3.24 metadata from Docker Hub (connection reset by peer), before repository tests ran; a later CGO run on the same commit passed. I also pushed 2f2e28d for the open review feedback. Local final validation is still in progress.

Initial plan

7365dc1

Copilot AI assigned Copilot and pelikhan Sep 4, 2026

Copilot started work on behalf of pelikhan September 4, 2026 22:31 View session

Copilot AI linked an issue Sep 4, 2026 that may be closed by this pull request

docker-sudo-iptables loses setup-ruby PATH before AWF #58458

Closed

Preserve setup PATH across privileged AWF

b438405

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix docker-sudo-iptables PATH issue with setup-ruby in AWF~~ Preserve setup-action PATH across privileged AWF startup Sep 4, 2026

Copilot finished work on behalf of pelikhan September 4, 2026 22:59

Copilot AI requested a review from pelikhan September 4, 2026 22:59

pelikhan marked this pull request as ready for review September 4, 2026 23:03

Copilot AI balanced review requested due to automatic review settings September 4, 2026 23:03

Copilot started reviewing on behalf of pelikhan September 4, 2026 23:04 View session

Copilot AI reviewed Sep 4, 2026

View reviewed changes

github-actions Bot added pr-action:fast_track pr-agent:copilot pr-batch:awf-runtime pr-priority:high pr-risk:medium pr-type:bug labels Sep 5, 2026

github-actions Bot mentioned this pull request Sep 5, 2026

[PR Triage Report] PR triage report 2026-09-05 #58681

Closed

github-actions Bot reviewed Sep 5, 2026

View reviewed changes

github-actions Bot mentioned this pull request Sep 5, 2026

[pr-sous-chef] PR Sous Chef run report #58638

Open

Copilot started work on behalf of gh-aw-bot September 5, 2026 01:56 View session

Copilot AI and others added 2 commits September 5, 2026 02:00

Plan PR finishing pass

ff8210a

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Address AWF path review feedback

2f2e28d

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

pelikhan merged commit bfb4441 into main Sep 5, 2026

pelikhan deleted the copilot/fix-docker-sudo-iptables-path-issue branch September 5, 2026 02:13

Copilot AI requested a review from gh-aw-bot September 5, 2026 02:14

Copilot stopped work on behalf of gh-aw-bot due to an error September 5, 2026 02:14
The session was cancelled by the user.

Uh oh!

Conversation

Copilot AI commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 5, 2026

Uh oh!

github-actions Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 5, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

github-actions Bot Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Sep 5, 2026

Uh oh!

Copilot AI commented Sep 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Sep 4, 2026 •

edited

Loading

github-actions Bot commented Sep 5, 2026 •

edited

Loading

github-actions Bot commented Sep 5, 2026 •

edited

Loading

github-actions Bot commented Sep 5, 2026 •

edited

Loading

github-actions Bot commented Sep 5, 2026 •

edited

Loading

github-actions Bot commented Sep 5, 2026 •

edited

Loading