Fix Linear and Jira smoke issue creation - #58632
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job
Fix Linear and Jira smoke issue creation
Sep 4, 2026
pelikhan
reviewed
Sep 5, 2026
| engine: copilot | ||
| safe-outputs: | ||
| env: | ||
| JIRA_BASE_URL: https://pelidehalleux.atlassian.net |
Collaborator
There was a problem hiding this comment.
@copilot the compiler should use this env by default.
Contributor
Author
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Project resolution is repeated per issue, UUID passthrough lacks coverage, and an unrelated schema change needs separation or justification.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes Linear and Jira safe-output issue creation in the smoke workflow.
Changes:
- Resolves Linear project slugs to UUIDs before issue creation.
- Configures the Jira base URL and recompiles the workflow.
- Allows null
workflow_callschema values.
File summaries
| File | Description |
|---|---|
actions/setup/js/linear_create_issue.cjs |
Adds Linear project resolution. |
actions/setup/js/linear_safe_outputs.test.cjs |
Tests slug resolution. |
.github/workflows/smoke-issues.md |
Configures Jira URL. |
.github/workflows/smoke-issues.lock.yml |
Regenerates compiled workflow. |
pkg/workflow/schemas/github-workflow.json |
Expands workflow_call validation. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 3
- Review effort level: Balanced
| if (LINEAR_UUID_PATTERN.test(projectId)) { | ||
| input.projectId = projectId; | ||
| } else { | ||
| const projectData = await linearGraphQL(LINEAR_RESOLVE_PROJECT, { slugId: projectId }); |
Comment on lines
+33
to
36
| fetch | ||
| .mockResolvedValueOnce(response({ data: { projects: { nodes: [{ id: "a3f91a0b-6d71-4c58-a4bb-72b925bbebc8" }] } } })) | ||
| .mockResolvedValueOnce(response({ data: { issueCreate: { success: true, issue: { id: "id", identifier: "ENG-1", title: "Safe title" } } } })); | ||
| const handler = await createIssue({ team_id: "9cfb482a-81e3-4154-b5b9-2c805e70a02d", project_id: "810f57a7e383" }); |
Comment on lines
+1948
to
1953
| "oneOf": [ | ||
| { | ||
| "type": "null" | ||
| }, | ||
| { | ||
| "type": "object", |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Collaborator
@copilot Please take the next forward-progress pass on this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Smoke Issues workflow failed because Jira lacked its base URL and Linear received a project URL identifier where
issueCreaterequires a model UUID.Linear
Jira
Coverage