Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Docker.ignore #2997

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add Docker.ignore #2997

wants to merge 1 commit into from

Conversation

kobiam
Copy link

@kobiam kobiam commented Mar 13, 2019

Reasons for making this change:

adding Dockerfile for docker users

Links to documentation supporting these rule changes:

https://docs.docker.com/engine/reference/builder/#dockerignore-file

If this is a new template:

docker.com

@polarathene
Copy link

polarathene commented Apr 5, 2019

You linked to docs about the .dockerignore file.. That is not a .gitignore file, it serves a different purpose, it's for ignoring files when building Docker images rather than files to ignore when working with git..

This PR should be rejected. You don't appear to understand what you're contributing.

@shiftkey
Copy link
Member

shiftkey commented Apr 5, 2019

@kobiam while .dockerignore looks similar to a .gitignore file, their use cases are different enough and a potential source of confusion that I think this should not be added.

Without more information about what this template represents and why it's important, I cannot take in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants