Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignore on *.DotSettings.user since it's covered in *.user and keep publi… #3812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adameska
Copy link

…sh settings since private info is in the pubxml.user

Reasons for making this change:

Everytime i add a publish profile to a new solution i always get tripped up because pubxml is ignored... this is a huge pain since i want the server name etc in there. Passwords are already stored hidden in the pubxml.user which is ignored.

…sh settings since private info is in the pubxml.user
@bdougie
Copy link
Contributor

bdougie commented Dec 11, 2021

Is this a problem just for you? Can you point to any public discussions on this issue?

@adameska
Copy link
Author

No, this is a problem for anyone I've talked with, they general don't use the VS .gitignore for this issue and just re-use their own. I did not look at any public discussion but if you create a new repo with this gitignore, then create a publish profile to push to azure or w/e server you want, check your code in, then try and reference that publish profile on your build server it will fail (because publish profiles being checked in is ignored by default). I don't see how that's a good thing?

@adameska
Copy link
Author

I guess the main reason this was ignored was because connection strings to databases fully get stored in the pubxml? Is that the reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants