fix: Use the output_file variable in issue_metrics.py

[jakeatoms]

Pull Request

Proposed Changes

Resolves #479

When the OUTPUT_FILE env variable is specified in a calling Action, it is used everywhere except when checking for file size and splitting into multiple files. The default issue_metrics.md name was hardcoded.

This PR updates the script to use the provided output_file name and uses that naming as the basis for the smaller file names.

Readiness Checklist

Author/Contributor

• If documentation is needed for this change, has that been included in this pull request
• run make lint and fix any issues that you have introduced
• run make test and ensure you have test coverage for the lines you are introducing
• If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

• Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

[jmeridth]

@jakeatoms great addition. Thank you. Could you please alter or add some new tests to ensure this doesn't regress?

[jakeatoms]

@jakeatoms great addition. Thank you. Could you please alter or add some new tests to ensure this doesn't regress?

Will do!

[jakeatoms]

@jakeatoms great addition. Thank you. Could you please alter or add some new tests to ensure this doesn't regress?

@jmeridth OK, to accomplish testing without strictly testing main, I extracted the code that works with the output file to a separate function and tested that directly. We're now testing interaction with the various function calls and covering True and False scenarios. It's still not strictly testing that main isn't passing a hardcoded value, but to test that would involve a huge amount of mocking.

Let me know if you think this is sufficient, thanks!