Skip to content

Conversation

markacianfrani
Copy link
Contributor

#14
https://github.com/github/models-ai-sdk/issues

the npm package dist is empty. pretty sure it's because --ignore-scripts skips prePublish.

also updated the models

@markacianfrani markacianfrani requested a review from a team as a code owner October 6, 2025 15:16
@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 15:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the npm package distribution was empty by removing the --ignore-scripts flag from the publish command, allowing prepublish scripts to run properly. It also updates the available GitHub models by adding new GPT-5 variants and removing deprecated Phi-3 models.

  • Removes --ignore-scripts flag from npm publish command to ensure prepublish scripts execute
  • Adds new OpenAI GPT-5 model variants (gpt-5, gpt-5-chat, gpt-5-mini, gpt-5-nano)
  • Removes deprecated Microsoft Phi-3 model variants

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/publish.yml Removes --ignore-scripts flag to allow prepublish scripts to run during npm publish
src/model-id.ts Updates model list by adding GPT-5 variants and removing Phi-3 models

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@maraisr maraisr merged commit 103bddb into github:main Oct 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants