Fix template literal types in TypeScript. #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stanza dealing
template_literal_type
syntax nodes is too liberal in its capturing of inner types, causing it to capturestring_fragment
syntax nodes and fail creating edges with an error like:Restricting the inner type capture to just
template_type
syntax node fixes the issue. As of v0.23.2 of the Tree-sitter TypeScript grammar thetemplate_literal_type
only allowsstring_fragment
andtemplate_type
children, so this fix should be fine. Copious testing (on this repo’s TypeScript test suite and on all of microsoft/vscode) reveals no negative side effects.