Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo:rerun-if-changed to README #6

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Add cargo:rerun-if-changed to README #6

merged 1 commit into from
Jan 24, 2024

Conversation

look
Copy link
Member

@look look commented Jan 23, 2024

Generally you would want to cargo:rerun-if-changed on all your protos
to avoid unnecessary re-runs of the build.rs script. I added it to the
example.

Generally you would want to `cargo:rerun-if-changed` on all your protos
to avoid unnecessary re-runs of the build.rs script. I added it to the
example.
@look look requested a review from a team as a code owner January 23, 2024 22:03
@ospo-bot
Copy link

Hello from the #ospo!

We're rolling out a new org-wide workflow to check pull requests and are adding comments like this to a small number of PRs to raise awareness that you may see the check stuck in the Expected state for PRs that were already open when the check was turned on.

OSPO License Check looks for newly-added open source dependencies that have licenses outside of our policy.

If this pull request adds new open source dependencies to the project (for example, by changing package.json to include an additional npm package), please trigger the workflow by taking one of the following steps. Otherwise, you can safely ignore this message.

  1. You can push another commit
  2. You can update the branch
  3. You can close and reopen the PR (note that this could potentially trigger
    changes to project boards or cause bots to add comments)

To assist in rolling out this check smoothly, we're starting out the check in "evaluation" mode (not required for merging) and may also provide fairly broad ability to bypass the check once we make the workflow required.

If you have any questions or feedback, please let us know in the #ospo channel.

@patrickt patrickt merged commit e67dc5f into main Jan 24, 2024
1 check passed
@patrickt patrickt deleted the look/rerun-if branch January 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants