Skip to content

Add About page and update navigation to include GHAS information #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

CalinL
Copy link
Contributor

@CalinL CalinL commented Apr 25, 2025

No description provided.

Copy link

github-actions bot commented Apr 25, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA e7cd762.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@CalinL CalinL requested a review from Copilot April 25, 2025 11:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a dedicated About page describing GitHub Advanced Security and updates the site navigation to incorporate links to this page.

  • Added a new About page (both view and page model)
  • Updated the shared layout and Index page to include navigation links to the About page

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/webapp01/Pages/Shared/_Layout.cshtml Added a navigation link to the About page
src/webapp01/Pages/Index.cshtml Included an About page link in the main content area
src/webapp01/Pages/About.cshtml.cs Added a new PageModel for the About page
src/webapp01/Pages/About.cshtml Created the About page with GHAS details
Comments suppressed due to low confidence (2)

src/webapp01/Pages/Shared/_Layout.cshtml:27

  • [nitpick] Consider aligning the link text with the page title ('About GitHub Advanced Security') for consistency.
<a class="nav-link text-dark" asp-area="" asp-page="/About">About GHAS</a>

src/webapp01/Pages/Index.cshtml:11

  • [nitpick] Ensure consistency between the navigation label 'About GHAS' and the page title 'About GitHub Advanced Security' to avoid user confusion.
<p class="card-text">Visit our <a asp-page="/About">About GHAS</a> page to learn about GitHub Advanced Security features.</p>

@CalinL CalinL merged commit 9bac76b into main Apr 25, 2025
29 checks passed
@CalinL CalinL deleted the feature/about-page branch April 25, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant