Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds create pr urls for other providers #4143

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Adds create pr urls for other providers #4143

wants to merge 9 commits into from

Conversation

eamodio
Copy link
Member

@eamodio eamodio commented Mar 12, 2025

Refs #4142

@eamodio eamodio mentioned this pull request Mar 12, 2025
Open
9 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 12, 2025
View reviewed changes
src/git/remotes/bitbucket-server.ts
protected override getUrlForComparison(base: string, compare: string, _notation: '..' | '...'): string {
return this.encodeUrl(`${this.baseUrl}/branches/compare/${base}%0D${compare}`).replace('%250D', '%0D');
protected override getUrlForComparison(base: string, head: string, _notation: '..' | '...'): string {
return this.encodeUrl(`${this.baseUrl}/branches/compare/${base}%0D${head}`).replace('%250D', '%0D');

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This replaces only the first occurrence of '%250D'.

Copilot Autofix AI 8 days ago

To fix the problem, we need to ensure that all occurrences of the string '%250D' are replaced in the URL. This can be achieved by using a regular expression with the global flag (g) in the replace method. This change will ensure that every instance of '%250D' in the URL is replaced with '%0D'.

Suggested changeset 1
src/git/remotes/bitbucket-server.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/git/remotes/bitbucket-server.ts b/src/git/remotes/bitbucket-server.ts
--- a/src/git/remotes/bitbucket-server.ts
+++ b/src/git/remotes/bitbucket-server.ts
@@ -160,3 +160,3 @@
 	protected override getUrlForComparison(base: string, head: string, _notation: '..' | '...'): string {
-		return this.encodeUrl(`${this.baseUrl}/branches/compare/${base}%0D${head}`).replace('%250D', '%0D');
+		return this.encodeUrl(`${this.baseUrl}/branches/compare/${base}%0D${head}`).replace(/%250D/g, '%0D');
 	}
EOF
@@ -160,3 +160,3 @@
protected override getUrlForComparison(base: string, head: string, _notation: '..' | '...'): string {
return this.encodeUrl(`${this.baseUrl}/branches/compare/${base}%0D${head}`).replace('%250D', '%0D');
return this.encodeUrl(`${this.baseUrl}/branches/compare/${base}%0D${head}`).replace(/%250D/g, '%0D');
}
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Fixes compare and create-pr URLs for bitbucket-server
5003b13 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Fixes compare URL for bitbucket cloud
a0538f3 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 17, 2025
@sergeibbb
Fixes create-repo URL for bitbucket cloud
911b8b5 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 17, 2025
@sergeibbb
Gets provider resource URL asyncronously
fd15fa5 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 17, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
e2ca401 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
38021ba 
…k PR

(#4142, #4143)
@sergeibbb
Adds support for comparison and create pull request URLs in remote se…
37c92d9 
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
@sergeibbb
Gets provider resource URL asyncronously
7804bbf 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Adds support for comparison and create pull request URLs in remote se…
9877724 
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Fixes compare and create-pr URLs for bitbucket-server
cede65a 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Fixes compare URL for bitbucket cloud
e7491b9 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Fixes create-repo URL for bitbucket cloud
aa105d0 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Gets provider resource URL asyncronously
5dc1f5d 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
ac01ae2 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
4705650 
…k PR

(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
95f5d83 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
f470126 
…k PR

(#4142, #4143)
@sergeibbb sergeibbb force-pushed the feature/create-prs branch from 38021ba to f470126 Compare March 18, 2025 21:24
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
e75a70b 
(#4142, #4143)
@sergeibbb sergeibbb force-pushed the feature/create-prs branch from f470126 to d324a33 Compare March 19, 2025 09:55
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
d324a33 
…k PR

(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes compare and create-pr URLs for bitbucket-server
b206ae0 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes compare URL for bitbucket cloud
5fedf22 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes create-repo URL for bitbucket cloud
b2a27c8 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Gets provider resource URL asyncronously
df66dfb 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
a87cac0 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
0ce9e8b 
…k PR

(#4142, #4143)
@sergeibbb sergeibbb force-pushed the feature/create-prs branch from d324a33 to 2f19e0e Compare March 19, 2025 12:55
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes compare and create-pr URLs for bitbucket-server
aa4883f 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes compare URL for bitbucket cloud
33c1c1a 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes create-repo URL for bitbucket cloud
e37377d 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Gets provider resource URL asyncronously
1a2f6d8 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
c4e405d 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
14dcad6 
…k PR

(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Generates create Bitbucket PR URLs and retrieves repoId for cross-forks
3c8f601 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes compare and create-pr URLs for bitbucket-server
621a3fc 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes compare URL for bitbucket cloud
ca318d2 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes create-repo URL for bitbucket cloud
4875863 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Gets provider resource URL asyncronously
019613b 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
970f67f 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
1285578 
…k PR

(#4142, #4143)
@sergeibbb sergeibbb force-pushed the feature/create-prs branch from 3c8f601 to fcfae9b Compare March 19, 2025 13:24
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes compare and create-pr URLs for bitbucket-server
9347eac 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes compare URL for bitbucket cloud
c1e5b26 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes create-repo URL for bitbucket cloud
1180000 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Gets provider resource URL asyncronously
8c80905 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
ddc5f30 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
2bdc93c 
…k PR

(#4142, #4143)
@sergeibbb sergeibbb linked an issue Mar 19, 2025 that may be closed by this pull request
Create Pull Request action fails for remotes other than GitHub #4142
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Pull Request action fails for remotes other than GitHub
2 participants
@eamodio @sergeibbb