Skip to content

Add associations count for users #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

sichapman
Copy link
Contributor

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good addition.

Can you please put an example JSON file example (ideally coming from a running GitLab installation, or coming from the GitLab documentation) in gitlab4j-models/src/test/resources/org/gitlab4j/models

And add a new test case like this:

@Test
public void testAccessRequest() throws Exception {
AccessRequest accessRequest = unmarshalResource(AccessRequest.class, "access-request.json");
assertTrue(compareJson(accessRequest, "access-request.json"));
}

To make sure that the new Associations model can be serialised and deserialised as expected?

@jmini jmini merged commit 6f2f878 into gitlab4j:main Apr 22, 2025
2 checks passed
@jmini
Copy link
Collaborator

jmini commented Apr 22, 2025

🎉 I have added the missing test and test file, and I have merged your PR. Thank you for this contribution!

@sichapman sichapman deleted the associations-count branch April 23, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants