Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable automatic instance hopping for Flex #190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Mar 27, 2025

Description

For an easier migration to Flex, automatically change the Gitpod host to app.gitpod.io when users visit it.

Sister PR to https://github.com/gitpod-io/gitpod-next/pull/5806.

@filiptronicek filiptronicek requested a review from Copilot March 27, 2025 12:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request automatically redirects users from gitpod.io and related domains to app.gitpod.io to better support the migration to Flex.

  • Updated content script configuration to include app.gitpod.io in the matches array.
  • Modified the endpoint update logic to use window.location.href instead of a precomputed currentHost.
Comments suppressed due to low confidence (1)

src/contents/gitpod-dashboard.ts:35

  • Switching from currentHost to window.location.href may include unwanted URL parts (such as query parameters) that could impact endpoint parsing. Consider using a sanitized or consistent version of the host value to avoid unintended behavior.
await storage.set(STORAGE_KEY_ADDRESS, parseEndpoint(window.location.href));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant