Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-up] Auto-login if GITPOD_IMAGE_AUTH is set #20545

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

geropl
Copy link
Member

@geropl geropl commented Jan 24, 2025

Description

So far GITPOD_IMAGE_AUTH had two issues:

  • it was not present in the default env in terminals, although it was present in gp env
  • it was used for pulling docker images in image builder, but not used in workspaces to authenticated the docker daemon
    This PR fixes both issues.

Related Issue(s)

Fixes CLC-1098

How to test

  • join this org
  • start a workspace, and note:
    • env | grep GITPOD_IMAGE_AUTH is not empty
    • test gp validate:
      • change first line in .gitpod.yml to image: geropl/workspace-base:latest
      • hit gp validate and note how it successfully pulls the base image

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants