-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] add feature flags for spicedb client options #20613
base: main
Are you sure you want to change the base?
Conversation
Tool: gitpod/catfood.gitpod.cloud
750adeb
to
b45b492
Compare
Tool: gitpod/catfood.gitpod.cloud
@mustard-mh because the API calls on the preview environment seem to be succeeding, I assume SpiceDB is doing fine. Could you update the description in the PR or in Linear to outline:
|
Thanks @filiptronicek , this PR is related to this internal chat that we want to try different grpc options.
Not sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mustard-mh I see, thanks for sharing. I don't have anything against this, so unblocking.
Rage-clicked LGTM here, so you get two approvals :P |
Co-authored-by: Gero Posmyk-Leinemann <[email protected]> Tool: gitpod/catfood.gitpod.cloud
Description
[server] add feature flags for spicedb client options
The default value of the feature flag is
undefined
. If the feature flag is set to this value, we will use the default spicedb grpc client options, otherwise the value should be a valid json.Related Issue(s)
Relates CLC-370 (internal chat)
How to test
JSON.stringify
grpc client optionsDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold