Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix our use of yq #1537

Closed
wants to merge 1 commit into from
Closed

Fix our use of yq #1537

wants to merge 1 commit into from

Conversation

filiptronicek
Copy link
Member

Description

Looks like yq got updated under our feet somehow. This PR makes sure that doesn't scare us too much

Tool: gitpod/catfood.gitpod.cloud
@filiptronicek filiptronicek requested review from a team as code owners March 14, 2025 08:55
@filiptronicek filiptronicek enabled auto-merge (squash) March 14, 2025 08:55
@geropl
Copy link
Member

geropl commented Mar 14, 2025

@filiptronicek Looks like the version bump from 3 -> 4.

Before, we would have explicit names e.g. yq4 in some places.

If we update this:

  • How do we make sure we don't break customers?
  • How do we make sure we don't break ourselves?

IMO it would be worth investigating where exactly the bump is coming from, just to make sure we are aligned with the wider ecosystem 👍

@filiptronicek
Copy link
Member Author

@geropl you've got a very good point – thanks for stopping by and raising it. Turns out, this was actually happening because of my dotfiles installing yq through nix, which actually meant that yq was at version 3.4.3! (and not 4.22.1, as our ws image provides).

Blaming it all on Nix for not having up-to-date pkgs :P

auto-merge was automatically disabled March 14, 2025 09:17

Pull request was closed

@filiptronicek filiptronicek deleted the ft/fix-build-chunk-script branch March 14, 2025 09:18
@geropl
Copy link
Member

geropl commented Mar 14, 2025

Turns out, this was actually happening because of my dotfiles installing yq through nix, which actually meant that yq was at version 3.4.3! (and not 4.22.1, as our ws image provides).

Wow, that was actually unexpected - thanks for figuring that out! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants