Commented out Bluesky alt text line #651
Conversation
Commented out the alt text line for now until there is a way to set this from within Postiz
|
@FoamToaster is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe change involves modifying the Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Your PR's base branch was set to |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libraries/nestjs-libraries/src/integrations/social/bluesky.provider.ts (1)
193-197: Temporary Removal of Default Alt Text for ImagesThe change correctly comments out the assignment of the default alt text (
alt: 'image') to prevent unwanted visual effects with uploaded images. This temporary measure addresses the bug described in the PR objectives until a proper mechanism for setting or disabling alt text is implemented.Recommendations:
- Consider adding a clear TODO or note adjacent to this commented code (if not already clear) that references the planned enhancement for user-configurable alt text. This will help ensure the temporary measure is revisited when the feature is developed.
- Verify that omitting the alt text does not inadvertently affect accessibility requirements. If needed, plan to support an empty alt attribute or alternative handling to maintain a balance between visual correctness and accessibility.
Commented out the Bluesky alt text line for now until there is a way to set this from within Postiz.
What kind of change does this PR introduce?
Bug fix
Why was this change needed?
Current code assigns alt text 'image' to every uploaded image. Presence of alt text adds bars/empty space above and below the posted image and when the image is clicked on the word 'image' is visible at the lower left. Absence of alt text fixes this problem. There does not seem to be a way to edit/disable the alt text from within Postiz so have commented it out for now (commented out rather than deleted as I presume this feature might be implemented at some point).
Other information:
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;
Summary by CodeRabbit