Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload tiktok images #655

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Upload tiktok images #655

merged 1 commit into from
Mar 14, 2025

Conversation

nevo-david
Copy link
Contributor

@nevo-david nevo-david commented Mar 14, 2025

Summary by CodeRabbit

  • New Features

    • Introduced an option in social media settings to automatically add music to posts.
    • Enhanced media management with improved image conversion capabilities and differentiated handling for photo versus video uploads.
    • Updated interface elements for more intuitive media selection and improved layout spacing.
  • Refactor

    • Applied internal formatting and validation improvements to enhance code readability and maintainability.

Copy link

coderabbitai bot commented Mar 14, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request implements several formatting improvements, debugging enhancements, and new functionality. The backend controller methods and frontend components have been reformatted for readability. Debug logs have been added to aid in form state validation. In the TikTok provider, UI changes and validation adjustments were made. Additionally, media processing in the posts service now supports conditional conversion of images to JPEG using new parameters and external libraries. The DTOs and integration interfaces have been updated to reflect these changes, ensuring consistent validation and enhanced media handling.

Changes

File(s) Change Summary
apps/backend/.../marketplace.controller.ts Reformatted parameters in connectBankAccount and post methods (multi-line adjustments) for improved readability; no logic changes.
apps/frontend/.../use.values.ts Added a logging statement (console.log(form.formState.errors)) to output form validation errors without affecting functionality.
apps/frontend/.../tiktok.provider.tsx Updated the yesNo array values from 'true'/'false' to 'yes'/'no'; added a new Select element for "Auto add music"; introduced the hideErrors property and adjusted layout and validation; added a new async method in the provider.
libraries/nestjs-libraries/src/database/prisma/posts/posts.service.ts Enhanced updateMedia: now accepts a convertToJPEG parameter, processes images with conditional PNG-to-JPEG conversion via axios, sharp, and UploadFactory; updated getPost and postSocial signatures accordingly.
libraries/nestjs-libraries/src/dtos/posts/providers-settings/tiktok.dto.ts Added a new property autoAddMusic (with 'yes'/'no' constraints) and commented out the isValidVideo property and its validations.
libraries/nestjs-libraries/src/integrations/social/social.integrations.interface.ts Introduced an optional property convertToJPEG to indicate JPEG conversion requirements.
libraries/nestjs-libraries/src/integrations/social/tiktok.provider.ts Modified postingMethod to include an isPhoto parameter; added a convertToJPEG property; updated the post request logic to conditionally include auto_add_music and improved error handling with Buffer inclusion.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PostsService
    participant Axios
    participant Sharp
    participant UploadFactory

    User->>PostsService: Call updateMedia(..., convertToJPEG=true)
    PostsService->>PostsService: Iterate over imagesList and check conditions
    alt Image requires conversion
        PostsService->>Axios: Fetch PNG image
        Axios-->>PostsService: Return image stream
        PostsService->>Sharp: Convert PNG to JPEG
        Sharp-->>PostsService: Return JPEG buffer
        PostsService->>UploadFactory: Upload JPEG image
        UploadFactory-->>PostsService: Return new image URL
    else No conversion needed
        PostsService->>PostsService: Process image as is
    end
    PostsService->>User: Return updated media information
Loading
sequenceDiagram
    participant Client
    participant TikTokProvider
    participant API

    Client->>TikTokProvider: Request to post content
    TikTokProvider->>TikTokProvider: Determine media type (photo or video)
    TikTokProvider->>TikTokProvider: Call postingMethod(isPhoto) to select endpoint
    TikTokProvider->>API: Send POST request with data (includes auto_add_music if photo)
    API-->>TikTokProvider: Return success response or error
    alt Error occurs
      TikTokProvider->>TikTokProvider: Capture error and wrap post data in Buffer
      TikTokProvider->>Client: Return error details
    end
Loading

Suggested reviewers

  • A1exKH
  • egelhaus

Poem

I'm a rabbit of code, bouncing with delight,
Hopping through changes from morning till night.
Clear logs and neat lines make my heart sing,
With JPEG conversions and UI bling.
Onward we hop in this code forest so bright! 🐰🌟

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3de66b7 and 8399aee.

📒 Files selected for processing (7)
  • apps/backend/src/api/routes/marketplace.controller.ts (2 hunks)
  • apps/frontend/src/components/launches/helpers/use.values.ts (1 hunks)
  • apps/frontend/src/components/launches/providers/tiktok/tiktok.provider.tsx (9 hunks)
  • libraries/nestjs-libraries/src/database/prisma/posts/posts.service.ts (6 hunks)
  • libraries/nestjs-libraries/src/dtos/posts/providers-settings/tiktok.dto.ts (1 hunks)
  • libraries/nestjs-libraries/src/integrations/social/social.integrations.interface.ts (1 hunks)
  • libraries/nestjs-libraries/src/integrations/social/tiktok.provider.ts (4 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nevo-david nevo-david merged commit dd60c93 into main Mar 14, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant