-
Notifications
You must be signed in to change notification settings - Fork 45
docs(oidc): add genric oidc doc #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@DrummyFloyd is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
""" WalkthroughA new documentation page titled "OIDC Configuration" has been added. This page provides step-by-step instructions on configuring OpenID Connect (OIDC) authentication for the application, using Authentik as an example provider. It explains the required environment variables, their purposes, and includes example values. The documentation also notes that enabling OIDC will disable GitHub login and mentions that similar steps apply to other OIDC providers such as Keycloak or Dex. No changes were made to code or exported entities. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (5)
pages/configuration/oauth.mdx (5)
13-16
: Refine instructional phrasing.
Improve clarity and fix missing articles:-If you want to use OAUTH/OIDC, please follow the following instruction. +If you want to use OAuth/OIDC, please follow these instructions. -We will use [Authentik](https://goauthentik.io/) as OIDC provider example. +We will use [Authentik](https://goauthentik.io/) as an OIDC provider example.🧰 Tools
🪛 LanguageTool
[uncategorized] ~13-~13: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...OAUTH/OIDC, please follow the following instruction. We will use [Authentik](https://goaut...(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[uncategorized] ~15-~15: You might be missing the article “an” here.
Context: ...Authentik as OIDC provider example. ### Create ...(AI_EN_LECTOR_MISSING_DETERMINER_AN)
17-19
: Add missing article in heading.
Include “the” for readability:-### Create an Application/Provider on Authentik side +### Create an Application/Provider on the Authentik side🧰 Tools
🪛 LanguageTool
[uncategorized] ~19-~19: You might be missing the article “the” here.
Context: ... ### Create an Application/Provider on Authentik side you will end some important infor...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
33-33
: Grammar in note.
Ensure subject–verb agreement and pluralization:-**Note**: same information need to be configured on other OIDC provider like Keycloak, Dex, etc. +**Note**: the same information needs to be configured on other OIDC providers such as Keycloak, Dex, etc.🧰 Tools
🪛 LanguageTool
[uncategorized] ~33-~33: This verb does not appear to agree with the subject. Consider using a different form.
Context: .../userinfo/` Note: same information need to be configured on other OIDC provider...(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
[uncategorized] ~33-~33: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...ion need to be configured on other OIDC provider like Keycloak, Dex, etc. ### `POSTIZ_G...(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
47-51
: Typo in logo description.
Correct “oon” to “on”:-Will display the logo of the OIDC provider oon login page button. +Will display the logo of the OIDC provider on the login page button.
35-89
: Standardize example notation (optional).
To adhere to common editorial style, consider using “e.g.,” instead of “eg:” across all environment variable examples for consistency.🧰 Tools
🪛 LanguageTool
[uncategorized] ~45-~45: Possible missing preposition found.
Context: ... eg:Authentik
Will display the name the of the OIDC provider on login page. ##...(AI_HYDRA_LEO_MISSING_OF)
[uncategorized] ~45-~45: You might be missing the article “the” here.
Context: ...ay the name the of the OIDC provider on login page. ### `NEXT_PUBLIC_POSTIZ_OAUTH_LO...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/configuration/oauth.mdx
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
pages/configuration/oauth.mdx
[uncategorized] ~13-~13: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...OAUTH/OIDC, please follow the following instruction. We will use [Authentik](https://goaut...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[uncategorized] ~15-~15: You might be missing the article “an” here.
Context: ...Authentik as OIDC provider example. ### Create ...
(AI_EN_LECTOR_MISSING_DETERMINER_AN)
[uncategorized] ~19-~19: You might be missing the article “the” here.
Context: ... ### Create an Application/Provider on Authentik side you will end some important infor...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~33-~33: This verb does not appear to agree with the subject. Consider using a different form.
Context: .../userinfo/` Note: same information need to be configured on other OIDC provider...
(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
[uncategorized] ~33-~33: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...ion need to be configured on other OIDC provider like Keycloak, Dex, etc. ### `POSTIZ_G...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[uncategorized] ~45-~45: Possible missing preposition found.
Context: ... eg: Authentik
Will display the name the of the OIDC provider on login page. ##...
(AI_HYDRA_LEO_MISSING_OF)
[uncategorized] ~45-~45: You might be missing the article “the” here.
Context: ...ay the name the of the OIDC provider on login page. ### `NEXT_PUBLIC_POSTIZ_OAUTH_LO...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🔇 Additional comments (2)
pages/configuration/oauth.mdx (2)
1-4
: Frontmatter is well-formed.
The YAML frontmatter correctly defines thetitle
anddescription
metadata for the page.
6-7
: Imports are correctly declared.
Steps
andCallout
fromnextra/components
are properly imported and will render the step-by-step UI and warning callout.
f86d43b
to
1efb217
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (2)
pages/configuration/oauth.mdx (2)
8-11
: Fix warning typo and casing
The past review identified the same issues with “Github Login” casing and “disbaled” spelling.
Apply this diff:<Callout type="warning"> - **Warning:** With the actual implementation of the OIDC provider, Github Login - provider will be disbaled. + **Warning:** With the actual implementation of the OIDC provider, GitHub login + provider will be disabled. </Callout>
21-23
: Correct verb in instruction
A previous review flagged this. Change “end” to “find”:- you will end some important information like: + you will find some important information like:
🧹 Nitpick comments (8)
pages/configuration/oauth.mdx (8)
13-14
: Revise instruction phrasing
“follow the following instruction” is redundant. Consider:- If you want to use OAUTH/OIDC, please follow the following instruction. + If you want to use OAuth/OIDC, please follow the instructions below.🧰 Tools
🪛 LanguageTool
[uncategorized] ~13-~13: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...OAUTH/OIDC, please follow the following instruction. We will use [Authentik](https://goaut...(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
15-16
: Add missing article
Include “an” before “OIDC provider example” for clarity:- We will use [Authentik](https://goauthentik.io/) as OIDC provider example, with base URL `https://authentik.example.com` + We will use [Authentik](https://goauthentik.io/) as an OIDC provider example, with base URL `https://authentik.example.com`🧰 Tools
🪛 LanguageTool
[uncategorized] ~15-~15: You might be missing the article “an” here.
Context: ...Authentik as OIDC provider example, with base URL `https:...(AI_EN_LECTOR_MISSING_DETERMINER_AN)
19-19
: Include article before vendor name
Change “on Authentik side” to “on the Authentik side”:- ### Create an Application/Provider on Authentik side + ### Create an Application/Provider on the Authentik side🧰 Tools
🪛 LanguageTool
[uncategorized] ~19-~19: You might be missing the article “the” here.
Context: ... ### Create an Application/Provider on Authentik side you will end some important infor...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
23-31
: Normalize arrow spacing in list items
Ensure consistent spacing around=>
:- - `client_id` => `randomclientid` - - `client_secret` => `randomclientsecret` - - `auth_url` => `https://authentik.example.com/application/o/authorize/` - - `token_url` => `https://authentik.example.com/application/o/token/` - - `userinfo_url`=> `https://authentik.example.com/application/o/userinfo/` + - `client_id` => `randomclientid` + - `client_secret` => `randomclientsecret` + - `auth_url` => `https://authentik.example.com/application/o/authorize/` + - `token_url` => `https://authentik.example.com/application/o/token/` + - `userinfo_url` => `https://authentik.example.com/application/o/userinfo/`
33-33
: Fix grammar in note
“same information need” should be “the same information needs”:- **Note**: same information need to be configured on other OIDC provider like Keycloak, Dex, etc. + **Note**: the same information needs to be configured on other OIDC providers such as Keycloak, Dex, etc.🧰 Tools
🪛 LanguageTool
[uncategorized] ~33-~33: This verb does not appear to agree with the subject. Consider using a different form.
Context: .../userinfo/` Note: same information need to be configured on other OIDC provider...(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
[uncategorized] ~33-~33: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...ion need to be configured on other OIDC provider like Keycloak, Dex, etc. ### `POSTIZ_G...(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
35-39
: Use proper abbreviation for example
Replace “eg:” with “e.g.,” for consistency:- eg: `POSTIZ_GENERIC_OAUTH="true"` + e.g., `POSTIZ_GENERIC_OAUTH="true"`
41-46
: Correct description typo
Fix “name the of” and add “the” before “login page”:- Will display the name the of the OIDC provider on login page. + Will display the name of the OIDC provider on the login page.🧰 Tools
🪛 LanguageTool
[uncategorized] ~45-~45: You might be missing the article “the” here.
Context: ...ay the name the of the OIDC provider on login page. ### `NEXT_PUBLIC_POSTIZ_OAUTH_LO...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
47-52
: Fix typo in description
Correct “oon” to “on”:- Will display the logo of the OIDC provider oon login page button. + Will display the logo of the OIDC provider on the login page button.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/configuration/oauth.mdx
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
pages/configuration/oauth.mdx
[uncategorized] ~13-~13: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...OAUTH/OIDC, please follow the following instruction. We will use [Authentik](https://goaut...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[uncategorized] ~15-~15: You might be missing the article “an” here.
Context: ...Authentik as OIDC provider example, with base URL `https:...
(AI_EN_LECTOR_MISSING_DETERMINER_AN)
[uncategorized] ~19-~19: You might be missing the article “the” here.
Context: ... ### Create an Application/Provider on Authentik side you will end some important infor...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~33-~33: This verb does not appear to agree with the subject. Consider using a different form.
Context: .../userinfo/` Note: same information need to be configured on other OIDC provider...
(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
[uncategorized] ~33-~33: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...ion need to be configured on other OIDC provider like Keycloak, Dex, etc. ### `POSTIZ_G...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[uncategorized] ~45-~45: You might be missing the article “the” here.
Context: ...ay the name the of the OIDC provider on login page. ### `NEXT_PUBLIC_POSTIZ_OAUTH_LO...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🔇 Additional comments (2)
pages/configuration/oauth.mdx (2)
1-4
: Frontmatter looks good.
The title and description are clear and the YAML syntax is valid.
6-6
: Import statement is correct.
TheSteps
andCallout
components fromnextra/components
are properly imported.
1efb217
to
2272a79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (7)
pages/configuration/oauth.mdx (7)
13-13
: Improve grammar and casing in instruction sentenceThe sentence mixes uppercase “OAUTH/OIDC” and uses “instruction” singular. For clarity and consistency, use “OAuth/OIDC” and make it plural:
- If you want to use OAUTH/OIDC, please follow the following instruction. + If you want to use OAuth/OIDC, please follow the instructions below.🧰 Tools
🪛 LanguageTool
[uncategorized] ~13-~13: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...OAUTH/OIDC, please follow the following instruction. We will use [Authentik](https://goaut...(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
15-15
: Add missing article and refine phrasingInsert “an” before “OIDC provider example” for grammatical correctness:
- We will use [Authentik](https://goauthentik.io/) as OIDC provider example, with base URL `https://authentik.example.com` + We will use [Authentik](https://goauthentik.io/) as an OIDC provider example, with base URL `https://authentik.example.com`🧰 Tools
🪛 LanguageTool
[uncategorized] ~15-~15: You might be missing the article “an” here.
Context: ...Authentik as OIDC provider example, with base URL `https:...(AI_EN_LECTOR_MISSING_DETERMINER_AN)
19-19
: Add missing article in section titleThe heading would read more naturally with “the”:
- ### Create an Application/Provider on Authentik side + ### Create an Application/Provider on the Authentik side🧰 Tools
🪛 LanguageTool
[uncategorized] ~19-~19: You might be missing the article “the” here.
Context: ... ### Create an Application/Provider on Authentik side You will find the following impor...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
31-31
: Ensure consistent spacing around arrow in code snippetAdd spaces around
=>
to match other list items:- - `userinfo_url`=> `https://authentik.example.com/application/o/userinfo/` + - `userinfo_url` => `https://authentik.example.com/application/o/userinfo/`
33-33
: Fix verb agreement and pluralization in NoteAdjust to “needs” and pluralize “providers”:
- **Note**: same information need to be configured on other OIDC provider like Keycloak, Dex, etc. + **Note**: the same information needs to be configured on other OIDC providers like Keycloak, Dex, etc.🧰 Tools
🪛 LanguageTool
[uncategorized] ~33-~33: This verb does not appear to agree with the subject. Consider using a different form.
Context: .../userinfo/` Note: same information need to be configured on other OIDC provider...(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
[uncategorized] ~33-~33: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...ion need to be configured on other OIDC provider like Keycloak, Dex, etc. ### `POSTIZ_G...(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
45-45
: Remove extraneous word and correct prepositionClean up “the name the of” and add “the” before “login page”:
- Will display the name the of the OIDC provider on login page. + Will display the name of the OIDC provider on the login page.🧰 Tools
🪛 LanguageTool
[uncategorized] ~45-~45: Possible missing preposition found.
Context: ... eg:Authentik
Will display the name the of the OIDC provider on login page. ##...(AI_HYDRA_LEO_MISSING_OF)
[uncategorized] ~45-~45: You might be missing the article “the” here.
Context: ...ay the name the of the OIDC provider on login page. ### `NEXT_PUBLIC_POSTIZ_OAUTH_LO...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
51-51
: Correct typo in logo URL descriptionChange “oon” to “on the”:
- Will display the logo of the OIDC provider oon login page button. + Will display the logo of the OIDC provider on the login page button.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/configuration/oauth.mdx
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
pages/configuration/oauth.mdx
[uncategorized] ~13-~13: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...OAUTH/OIDC, please follow the following instruction. We will use [Authentik](https://goaut...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[uncategorized] ~15-~15: You might be missing the article “an” here.
Context: ...Authentik as OIDC provider example, with base URL `https:...
(AI_EN_LECTOR_MISSING_DETERMINER_AN)
[uncategorized] ~19-~19: You might be missing the article “the” here.
Context: ... ### Create an Application/Provider on Authentik side You will find the following impor...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~33-~33: This verb does not appear to agree with the subject. Consider using a different form.
Context: .../userinfo/` Note: same information need to be configured on other OIDC provider...
(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
[uncategorized] ~33-~33: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...ion need to be configured on other OIDC provider like Keycloak, Dex, etc. ### `POSTIZ_G...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[uncategorized] ~45-~45: Possible missing preposition found.
Context: ... eg: Authentik
Will display the name the of the OIDC provider on login page. ##...
(AI_HYDRA_LEO_MISSING_OF)
[uncategorized] ~45-~45: You might be missing the article “the” here.
Context: ...ay the name the of the OIDC provider on login page. ### `NEXT_PUBLIC_POSTIZ_OAUTH_LO...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging as soon as status check passes.
Related to gitroomhq/postiz-app#701
Summary by CodeRabbit