Open
Conversation
execution via the eventlistener sends the event object which breaks initSwiper's 'onlyNew' parameter, stopping existing swiper from initialising. also there was a problem with single = in param check i corrected
Author
|
i just went on a multi hour deep dive into errors thrown in slide nav via left panel even in live demo, and its due to false true of if (param[0] = '{') { fixed in this PR. problem is it corrupts the swiper dataset , so any swiper will need recreating to remove the json that has now been inserted into eg the navigation tag and thus overwrites the internal navigation object casing errors: Uncaught TypeError: can't access property "split", a.disabledClass is undefined |
Author
|
im wondering what code puts a json in a data attr ? and also does this code here also need json handling ability ? VvvebJs/libs/builder/components-elements.js Lines 1154 to 1160 in 078fe4f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execution via the eventlistener sends the event object which breaks initSwiper's 'onlyNew' parameter, stopping existing swiper from initialising.
also there was a problem with single = in param check i corrected