Various fixes to resolve barchart style inconsistencies#284
Open
nuxy wants to merge 4 commits intogizak:masterfrom
Open
Various fixes to resolve barchart style inconsistencies#284nuxy wants to merge 4 commits intogizak:masterfrom
nuxy wants to merge 4 commits intogizak:masterfrom
Conversation
fafg
reviewed
Mar 23, 2021
|
Hello! Thank you for contributing to termui. I've merged this PR into a downstream fork at https://github.com/dcorbe/termui-dpc This was done in response to the following issue: #304 (comment) My intention is not to create a permanent fork for termui. I'm only trying to facilitate maintenance while the original author(s) are away. My hope is that my fork is eventually merged back into this repo along with your commits. I would like to invite you to collaborate further. I would appreciate any help curating fixes and generally getting this project going in the right direction. Thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a couple changes to resolve UI inconsistencies I found when using this library. The overall goal is to have these items fixed upstream so I don't have to include a modified version of the
barchart.gofile in my project source.Proposed changes
Commit 1
The percent text value always starts from the bar center position.
While this looks great when working with one character
Datavalues (as pictured in the termui example) it looks awkward when dealing with long values since items greater thanBarWidth / 2end up bleeding into the next bar. The position should be calculated based on the character length andBarWidthsize available.Commit 2
The bar is not completely rendered when
Datavalues< 2%exist. I'm not sure this is intentional but the chart should maintain consistent sizing in regard to the bar width even if the value is1%or less.Before
After