Improve configuration: add 'align' and 'priority', and switch to actual objects#2
Open
cerlestes wants to merge 3 commits intogizak:masterfrom
Open
Improve configuration: add 'align' and 'priority', and switch to actual objects#2cerlestes wants to merge 3 commits intogizak:masterfrom
cerlestes wants to merge 3 commits intogizak:masterfrom
Conversation
add keys 'align' and 'priority' to configuration, and switch from comma-separated strings to actual objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes will allow users to configure a default alignment and priority for all added shortcut buttons, and also allow them to override those settings per shortcut by switching from a comma-separated string configuration to actual, extendable objects.
The change is non-breaking, as the introduced settings will fall back to the same behaviour, and the old string-setting parser is left intact.
Please change the added code as desired.