German skill tracking fix #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for tracking Beornings Execute and Brawlers Fist of the Valar in German. Possibly also Fixes other skills with same type of chat line.
|
I just created a (possibly bad) merge Request for the similar chat line on the Hunters "Steilschuss" My approach was to copy the whole section and edit the patterns - but yours looks more nicely done. btw. were you able to check if an absorbed or partly absorbed hit is covered too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for tracking Beornings Execute and Brawlers Fist of the Valar in German. Possibly also Fixes other skills with same type of chat line.
Fixes skills mentioned in #20 but since i dont play on German client not sure if there arent other skills not tracking.