feat: Upgrade to comrak 0.54 with math_latex + alert_style options, and changed header_ids#472
Merged
Conversation
Comrak 0.54 changes heading anchor markup: the id now lives on the heading element and the anchor moves to the end with an aria-label instead of a leading aria-hidden link. That output change is user-visible, so the affected tests are updated to match. Also picks up upstream fixes for CommonMark roundtripping and a crash with ordered lists nested in blockquotes.
Comrak 0.54 adds LaTeX-style math delimiters and semantic alert rendering (<aside class="admonition">, matching docutils). Exposing them keeps the gem's option surface in step with upstream.
gjtorikian
changed the title
Collaborator
|
All LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
math_latexextension option:\(...\)and\[...\]delimiters render as inline/display math spans.alert_stylerender option:"semantic"outputs<aside class="admonition">(matching docutils) instead of the defaultmarkdown-alertdivs.idnow lives on the heading element and the anchor moved to the end witharia-label+data-heading-content, replacing the leadingaria-hiddenlink. CSS/JS targeting the old markup will be affected — this warrants a minor version bump (2.9.0) and a prominent changelog entry.