firenvim.vim:get_windows_env_path: deal with inconsistent system() #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1683, the user reports that get_windows_env_path returns truncated values for %AppData%, and that replacing the `-3` to `-2` in the value returned by get_windows_env_path fixes this issue. On my machine, it seems that `-3` is still the correct value. This is weird, because system()'s `:help` says that CRs should be stripped from `system()`'s output, meaning that regardless of whether the system emits an NL or a CRNL, the string system returns should be consistent. We just shrug our shoulders at this mistery and start using trim() instead of hard-coding the amount of characters to remove from system()'s output in order to fix this. Closes #1683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1683, the user reports that get_windows_env_path returns truncated
values for %AppData%, and that replacing the
-3to-2in the valuereturned by get_windows_env_path fixes this issue.
On my machine, it seems that
-3is still the correct value. This isweird, because system()'s
:helpsays that CRs should be stripped fromsystem()'s output, meaning that regardless of whether the system emitsan NL or a CRNL, the string system returns should be consistent.
We just shrug our shoulders at this mistery and start using trim()
instead of hard-coding the amount of characters to remove from
system()'s output in order to fix this.
Closes #1683