gh-998: Change all references to len to .shape[0]#1032
Merged
paddyroddy merged 14 commits intomainfrom Jan 29, 2026
Merged
Conversation
len to .shape[0]len to .shape[0]
connoraird
approved these changes
Jan 29, 2026
Contributor
connoraird
left a comment
There was a problem hiding this comment.
I assume that the instances of size which are now shape[0] used to be len or are being applied to a cl?
Member
Author
See 6a12b05 |
Contributor
So are we not sure if they used to be |
Member
Author
I wasn't clear what you were asking. I guess not. |
Contributor
If we trust our tests then this is okay |
Member
Author
I probably don't... Will check tomorrow. |
Member
Author
I've been more cautious and reverted all of them unless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Array API spec doesn't have a definition of
len(). This PR changes.sizereferences to.shape[0]. It also changes some currentlen()to.shape[0].Closes: #998
Checks