Skip to content

gh-977: Actually test deprecated fields.py functions #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paddyroddy merged 3 commits into from
Jan 29, 2026
Merged

gh-977: Actually test deprecated fields.py functions #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
218f854
Call next on results
connoraird Jan 29, 2026
eb16d7e
Port generate
connoraird Jan 29, 2026
07ca31e
Update glass/fields.py
paddyroddy Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion glass/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,8 @@ def generate(
Sampled random fields.

"""
xp = array_api_compat.array_namespace(*gls, use_compat=False)

n = len(fields)
if len(gls) != n * (n + 1) // 2:
msg = "mismatch between number of fields and gls"
Expand All @@ -885,7 +887,7 @@ def generate(
grf = _generate_grf(gls, nside, ncorr=ncorr, rng=rng)

for t, x, var in zip(fields, grf, variances, strict=True):
yield t(x, var)
yield t(x, xp.asarray(var))


def glass_to_healpix_spectra(spectra: Sequence[T]) -> list[T]:
Expand Down
6 changes: 4 additions & 2 deletions tests/core/test_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,12 +410,14 @@ def test_generate_grf(compare: type[Compare], xp: ModuleType) -> None:

def test_generate_gaussian(xp: ModuleType) -> None:
with pytest.deprecated_call():
glass.generate_gaussian([xp.asarray([1.0, 0.5, 0.1])], 4)
result = glass.generate_gaussian([xp.asarray([1.0, 0.5, 0.1])], 4)
next(result)


def test_generate_lognormal(xp: ModuleType) -> None:
with pytest.deprecated_call():
glass.generate_lognormal([xp.asarray([1.0, 0.5, 0.1])], 4)
result = glass.generate_lognormal([xp.asarray([1.0, 0.5, 0.1])], 4)
next(result)


def test_generate(compare: type[Compare], xp: ModuleType) -> None:
Expand Down
Loading