gh-1076: Use array comparison functions from array-api-extra

[paddyroddy]

Description

As can be seen in scipy/scipy#25143 and scikit-learn/scikit-learn#34019, array-api-extra now provides array comparison methods. This means we should be able to remove our custom Compare helper class.

Closes: #1076

Changelog entry

Changed: Used array_api_extra.testing for array comparison in tests

Checks

• Is your code passing linting?
• Is your code passing tests?
• Have you added additional tests (if required)?
• Have you modified/extended the documentation (if required)?
• Have you added a one-liner changelog entry above (if required)?

[paddyroddy]

Failing tests

I know, that's because array-api-extra hasn't done a release. Can you review anyway?

[connoraird]

I stopped writing the same comment after a while but I think double checking the types of what we are comparing and making sure it should be assert_close or assert_equal would be good.

[paddyroddy]

I've done a find-and-replace and then iterated to include more assert_equal calls. But I don't agree that because something is float that we should necessarily use assert_close. If you consider the NumPy implementation it's to do with equality up to a tolerance. If that tolerance is 0, then they may as well be equal.

[paddyroddy]

Have merged in #1089

[lucascolley]

exams done, please do give https://github.com/data-apis/array-api-extra/releases/tag/v0.10.2 a test!

[lucascolley]

oops, made it to PyPI this time https://pypi.org/project/array-api-extra/

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.

[paddyroddy]

Merging now. Hope the exams went well @lucascolley!