gh-756: Run reg tests for relevant changes#774
Merged
paddyroddy merged 6 commits intomainfrom Nov 13, 2025
Merged
Conversation
connoraird
force-pushed
the
connor/only-run-reg-test-for-relevant-changes
branch
from
2d979b9 to
60c5569
Compare
connoraird
force-pushed
the
connor/only-run-reg-test-for-relevant-changes
branch
from
60c5569 to
01af4e6
Compare
paddyroddy
reviewed
Nov 13, 2025
| on: | ||
| pull_request: | ||
| paths: | ||
| - .github/workflows/regression-test.yml |
Member
There was a problem hiding this comment.
Suggested change
| - .github/workflows/regression-test.yml | |
| - .github/workflows/regression-test.yaml |
paddyroddy
reviewed
Nov 13, 2025
|
|
||
| on: | ||
| pull_request: | ||
| paths: |
Member
There was a problem hiding this comment.
Is this list definitely exhaustive? Always a bit nervous doing this
Contributor
Author
There was a problem hiding this comment.
I suppose the noxfile.py too and the benchmarks once they are merged into this repo
Contributor
Author
There was a problem hiding this comment.
The issue with not having this is we will end up running a lot of actions for no reason as we have tests and regression tests.
Member
There was a problem hiding this comment.
Appreciate that, but good to make sure we have all relevant paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Somehow this was missed. According to #756, we should only be running regression tests for relevant file changes (glass/* or dependencies i.e. pyproject.toml)
Fixes: #756
Checks