Skip to content

feat: docker swarm support #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 7, 2025

Conversation

asherAbecasiss
Copy link
Contributor

merged upstream main into branch and resolved conflicts, integrate Docker Compose and Swarm into a unified package.

…ate Docker Compose and Swarm into a unified package.
@pmig pmig changed the title feat: merged upstream main into branch and resolved conflicts, integr… feat: docker swarm support Mar 24, 2025
@pmig pmig requested a review from kosmoz March 24, 2025 18:27
Copy link
Member

@kosmoz kosmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asherAbecasiss! At first glance this looks promising.

The one thing I'm not sure about having the DockerType on the application version entity. That is because, as far as I understand (please correct me if I'm wrong), docker compose and docker stack are both built on the same file specification, where both ignore some parts that are not relevant. I think it might make more sense to have the DockerType on the deployment target entity, that way a vendor only has to create an application once and the customer can decide which type to use later. What do you think, would that work?

@kosmoz kosmoz force-pushed the docker-swarm-feature-v2 branch from 6e47e6d to 3d9bf49 Compare April 29, 2025 09:24
@kosmoz kosmoz requested a review from christophenne April 30, 2025 11:56
@kosmoz kosmoz requested a review from christophenne May 5, 2025 09:32
@pmig pmig linked an issue May 6, 2025 that may be closed by this pull request
@kosmoz kosmoz merged commit d842dda into glasskube:main May 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker swarm (stack deploy) support
3 participants