-
Notifications
You must be signed in to change notification settings - Fork 27
feat: docker swarm support #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: docker swarm support #645
Conversation
…ate Docker Compose and Swarm into a unified package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @asherAbecasiss! At first glance this looks promising.
The one thing I'm not sure about having the DockerType
on the application version entity. That is because, as far as I understand (please correct me if I'm wrong), docker compose
and docker stack
are both built on the same file specification, where both ignore some parts that are not relevant. I think it might make more sense to have the DockerType
on the deployment target entity, that way a vendor only has to create an application once and the customer can decide which type to use later. What do you think, would that work?
frontend/ui/src/app/applications/application-detail.component.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
6e47e6d
to
3d9bf49
Compare
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
merged upstream main into branch and resolved conflicts, integrate Docker Compose and Swarm into a unified package.