feat: docker swarm support #645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate Docker Compose and Swarm into a unified package.
pmig
changed the title
kosmoz
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Hi @asherAbecasiss! At first glance this looks promising.
The one thing I'm not sure about having the DockerType on the application version entity. That is because, as far as I understand (please correct me if I'm wrong), docker compose and docker stack are both built on the same file specification, where both ignore some parts that are not relevant. I think it might make more sense to have the DockerType on the deployment target entity, that way a vendor only has to create an application once and the customer can decide which type to use later. What do you think, would that work?
| validators: Validators.required, | ||
| }), | ||
| compose: new FormControl(''), | ||
| swarm: new FormControl(''), |
| @@ -210,14 +210,20 @@ func GetApplicationForApplicationVersionID(ctx context.Context, id, orgID uuid.U | |||
| } | |||
|
|
|||
| func CreateApplicationVersion(ctx context.Context, applicationVersion *types.ApplicationVersion) error { | |||
| // defaultDockerType := DockerTypeCompose | |||
| // av.Docker_Type = &defaultDockerType | |||
| fmt.Println("----------------->>>>>>>>>>>>", applicationVersion.Docker_Type) | |||
| ArchivedAt *time.Time `db:"archived_at" json:"archivedAt,omitempty"` | ||
| Name string `db:"name" json:"name"` | ||
| ApplicationID uuid.UUID `db:"application_id" json:"applicationId"` | ||
| Docker_Type *DockerType `db:"docker_type" json:"dockerType,omitempty"` |
| return errors.New("missing compose file") | ||
| if av.Docker_Type == nil || *av.Docker_Type == "" { | ||
| return errors.New("missing docker type") | ||
| } else if *av.Docker_Type == DockerTypeCompose && av.ComposeFileData == nil { |
There was a problem hiding this comment.
Wouldn't a "swarm" application also require a compose file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merged upstream main into branch and resolved conflicts, integrate Docker Compose and Swarm into a unified package.