Read rawBuffer for BitArray body instead of buffer
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Mar 23, 2025
ghivert
force-pushed
the
fix/bit-array-body
branch
from
95b2ef7 to
ad7e0fd
Compare
ghivert
force-pushed
the
fix/bit-array-body
branch
from
ad7e0fd to
e12b1b5
Compare
|
Sure, that's done! I wasn't 100% sure on how you wanted to handle backwards-compatibility, but maintaining only the latest version of Gleam seems perfect to me! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Currently, when on Gleam 1.9 and higher, reading
.bufferon BitArray displays a warning.That PR comes to fix that, but ensures a compatibility with old Gleam versions, so everyone can safely upgrade to next versions of
gleam_fetch, no matter which version of Gleam they're running on.As a matter of information, code has been tested on Gleam 1.9.1 and Gleam 1.6.0.
As I wasn't aware if the change should be in the Changelog or not, I did not update it (because it's a silent change for users).