Improve error message on types used as vars #4180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c077m4n
force-pushed
the
improve-warning-on-types-used-as-vars
branch
4 times, most recently
from
03c2610 to
b46847e
Compare
5c077m4n
force-pushed
the
improve-warning-on-types-used-as-vars
branch
from
b46847e to
612766e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4112
This is the simplest fix to improve the error message when using a type instead of a value (when it's not in scope).
Another approach could be to create a new error type, but that will lead to more code duplication and "tribal" knowledge (you have to check the variable's name before every creation of the error), WDYT?