Skip to content

Added a retirement notice when adding a retired package #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Added a retirement notice when adding a retired package #4491

wants to merge 1 commit into from
+28 −0

Conversation

vnikjr
Copy link

@vnikjr vnikjr commented Apr 20, 2025

implements #4476

Notes:

  • I'm not sure how to test this as i do not know any retired packages to test it on
  • this is my first pr, sorry if anything is off or unprofessional :)

lpil
lpil reviewed Apr 21, 2025
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Rather than making a new HTTP request for this let's keep this information from when we talk to the Hex API earlier during version resolution. This will be quite fiddly, but we don't want to be talking to the API in multiple places.

@lpil lpil marked this pull request as draft April 21, 2025 11:21
@vnikjr
Copy link
Author

vnikjr commented Apr 21, 2025

Could you clarify where i can get the RetirementStatus/ReleaseMeta of the package, i couldn't find where it were being requested during version resolution

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnikjr @lpil