-
-
Notifications
You must be signed in to change notification settings - Fork 815
Improve documentation printer #4529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve documentation printer #4529
Conversation
9817b90
to
14f928f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!! Thank you!!
Some small notes inline
...src/docs/snapshots/gleam_core__docs__tests__print_type_variables_in_function_signatures.snap
Show resolved
Hide resolved
14f928f
to
a9ecf46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! Thank you so much! I've added one small comment inline 🙏
d4f572a
to
11ed8c8
Compare
The links should all be correct now. These changes require a bit more plumbing as we now need information from the manifest about what specific version of a package is being used. |
This PR closes #2629, closes #828 and closes #3461
This PR is a continuation of #3471, thanks @yoshi-monster for doing the initial work!
What I've done in this PR:
docs::printer::Printer
struct.ZeroWidthString
variant to theDocument
enum in the pretty printing module