Remove unreferenced insta snapshots #5194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abs0luty
changed the title
abs0luty
force-pushed
the
check-unused-insta-snapshots
branch
6 times, most recently
from
8fb4580 to
7ae5773
Compare
lpil
reviewed
Dec 11, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Whoa, cool! I didn't realise you could do this.
abs0luty
force-pushed
the
check-unused-insta-snapshots
branch
16 times, most recently
from
c39ca78 to
884ab2e
Compare
lpil
reviewed
Jan 12, 2026
Member
|
This is getting a bit complex being done on CI. Maybe we could do this instead with a script that folks use in dev? |
Contributor
Author
|
@lpil Well I'm not sure about it, the whole point is to make CI check unreferenced snapshots so this thing doesn't interfere with most of the contributors' work. |
abs0luty
force-pushed
the
check-unused-insta-snapshots
branch
2 times, most recently
from
bc2d881 to
884ab2e
Compare
Member
|
There's not really any cost to having some outdated text files, so any checking on CI would need to also not have any cost. CI complexity is a headache, so any CI based approach would need to not introduce any cost there |
abs0luty
force-pushed
the
check-unused-insta-snapshots
branch
from
884ab2e to
5a627a3
Compare
abs0luty
changed the title
Contributor
Author
|
@lpil What do you think of adding new targets to the Makefile? Or should I just make the PR only remove unused snapshots at this point? |
abs0luty
changed the title
lpil
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes these unused snapshots
and adds a CI check to prevent unreferenced snapshots from being introduced in the future.