-
-
Notifications
You must be signed in to change notification settings - Fork 900
Fix formatter reordering comments in function type parameters #5229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| r#"pub fn main() -> #( | ||
| String, | ||
| // This is a string | ||
| String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test fix as per comment in conversation here: #5225 (comment)
|
Hey @robertDurst! Could you add a changelog entry (see existing entries for inspiration)? |
Done! Thanks for catching this @ankddev ... had the |
43bb33f to
65fbd1b
Compare
|
Ok, cleaned up the commit history, should be GTG for an initial review. Thanks in advance and happy holidays 🥳 🎄 |
Address #5225 .
Specifically, this PR:
comment_in_tuple_return_typeper conversations in Formatter reoders comments inside function types #5225.Tried my best to follow of convention. Long term goal here is to hopefully continue finding places to contribute, so nit picks of all sizes appreciated 😁