feat: improve unexpected label error message#5329
Merged
Merged
Conversation
ankddev
commented
Jan 28, 2026
ankddev
commented
Contributor
- Closes Improve error message on passing labeled arguments to a function with unlabeled arguments #5295
- The changes in this PR have been discussed beforehand in an issue
- The issue for this PR has been linked
- Tests have been added for new behaviour
- The changelog has been updated for any user-facing changes
giacomocavalieri
left a comment
giacomocavalieri
left a comment
Member
There was a problem hiding this comment.
Left a little comment inline!
Member
|
Ah it seems this has a conflict with main, would you mind rebasing? |
Contributor
Author
|
@giacomocavalieri Yeah, will rebase once I will be at home! |
ankddev
force-pushed
the
improve-unexpected-label-error
branch
from
January 29, 2026 12:45
2b367cc to
df4a4cd
Compare
ankddev
commented
Jan 29, 2026
Contributor
Author
There was a problem hiding this comment.
This one isn't subject of this PR, it was changed since I have runned Clippy
Contributor
Author
|
@giacomocavalieri Done! |
giacomocavalieri
approved these changes
Jan 29, 2026
Signed-off-by: Andrey <andrekabatareika@gmail.com>
Signed-off-by: Andrey <andrekabatareika@gmail.com>
Signed-off-by: Andrey <andrekabatareika@gmail.com>
Signed-off-by: Andrey <andrekabatareika@gmail.com>
Signed-off-by: Andrey <andrekabatareika@gmail.com>
Co-authored-by: Giacomo Cavalieri <giacomo.cavalieri@icloud.com>
lpil
force-pushed
the
improve-unexpected-label-error
branch
from
February 7, 2026 09:59
c7c2bdd to
499ec86
Compare
lpil
enabled auto-merge (rebase)
February 7, 2026 10:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.